Unskip some CapturedSnapshot and ReferenceCreator tests - #12084
Conversation
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (352.004 µs) : 329, 375
. : milestone, 352,
basic (310.576 µs) : 302, 319
. : milestone, 311,
loop (10.168 ms) : 10051, 10285
. : milestone, 10168,
section candidate
noprobe (362.782 µs) : 320, 405
. : milestone, 363,
basic (311.576 µs) : 303, 320
. : milestone, 312,
loop (9.002 ms) : 8994, 9009
. : milestone, 9002,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The unskipped tests exercise only test fixtures and do not alter shipped agent behavior. The new invokedynamic fixture compiles successfully as Java 8 bytecode and emits both expected invokedynamic instructions; the full Gradle suites could not run because this sandbox lacks the repository-required Java 25 toolchain.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 873e40a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 873e40a453
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Nice cleanup!
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Unskip some CapturedSnapshot and ReferenceCreator tests now that Java 26 has been released and we don't support Java 7
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]