Skip to content

Unskip some CapturedSnapshot and ReferenceCreator tests - #12084

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
sarahchen6/unskip-tests
Jul 27, 2026
Merged

Unskip some CapturedSnapshot and ReferenceCreator tests#12084
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
sarahchen6/unskip-tests

Conversation

@sarahchen6

Copy link
Copy Markdown
Contributor

What Does This Do

Unskip some CapturedSnapshot and ReferenceCreator tests now that Java 26 has been released and we don't support Java 7

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Jul 27, 2026
@datadog-prod-us1-5

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 27, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1785188237 1785188606
end_time 2026-07-27T21:38:47 2026-07-27T21:44:57
git_branch master sarahchen6/unskip-tests
git_commit_sha 9b7597b 873e40a
start_time 2026-07-27T21:37:18 2026-07-27T21:43:27
See matching parameters
Baseline Candidate
ci_job_id 1898103845 1898103845
ci_pipeline_id 127299473 127299473
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1785187674 1785187674

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-1.160ms; -0.993ms] or [-11.610%; -9.943%]
better
[-1.256ms; -1.077ms] or [-12.350%; -10.592%]
better
[-1.197ms; -1.027ms] or [-11.619%; -9.977%]
better
[-1.197ms; -1.015ms] or [-11.432%; -9.696%]
better
[+9.756op/s; +12.523op/s] or [+10.001%; +12.837%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-18.038µs; +32.642µs] or [-5.859%; +10.602%]
unstable
[-25.078µs; +46.634µs] or [-7.124%; +13.248%]
unstable
[-31.814µs; +60.677µs] or [-8.649%; +16.496%]
unstable
[-108.734µs; +92.076µs] or [-8.361%; +7.080%]
same
scenario:basic same same same unstable
[-189.973µs; -19.046µs] or [-16.305%; -1.635%]
unstable
[-158.687op/s; +158.687op/s] or [-6.665%; +6.665%]
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (352.004 µs) : 329, 375
.   : milestone, 352,
basic (310.576 µs) : 302, 319
.   : milestone, 311,
loop (10.168 ms) : 10051, 10285
.   : milestone, 10168,
section candidate
noprobe (362.782 µs) : 320, 405
.   : milestone, 363,
basic (311.576 µs) : 303, 320
.   : milestone, 312,
loop (9.002 ms) : 8994, 9009
.   : milestone, 9002,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 352.004 µs [329.261 µs, 374.748 µs]
basic 310.576 µs [302.389 µs, 318.764 µs]
loop 10.168 ms [10.051 ms, 10.285 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 362.782 µs [320.347 µs, 405.218 µs]
basic 311.576 µs [303.377 µs, 319.775 µs]
loop 9.002 ms [8.994 ms, 9.009 ms]

@dd-octo-sts

dd-octo-sts Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.00 s [-0.5%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.89 s 13.02 s [-1.9%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 16.96 s 16.81 s [-0.1%; +1.9%] (no difference)
startup:petclinic:iast:Agent 16.92 s 16.87 s [-0.6%; +1.1%] (no difference)
startup:petclinic:profiling:Agent 16.74 s 16.25 s [-1.6%; +7.6%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.82 s [-0.3%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.05 s 16.17 s [-1.6%; +0.1%] (no difference)

Commit: d548307f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6
sarahchen6 marked this pull request as ready for review July 27, 2026 22:08
@sarahchen6
sarahchen6 requested review from a team as code owners July 27, 2026 22:08
@sarahchen6
sarahchen6 requested review from mcculls and ojung and removed request for a team July 27, 2026 22:08

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The unskipped tests exercise only test fixtures and do not alter shipped agent behavior. The new invokedynamic fixture compiles successfully as Java 8 bytecode and emits both expected invokedynamic instructions; the full Gradle suites could not run because this sandbox lacks the repository-required Java 25 toolchain.

Was this helpful? React 👍 or 👎

📊 Validated against 1 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 873e40a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 873e40a453

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-27 22:28:33 UTC ℹ️ Start processing command /merge


2026-07-27 22:28:38 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-27 23:32:21 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4e1a3cc into master Jul 27, 2026
597 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/unskip-tests branch July 27, 2026 23:32
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants