Add @ForegroundSafe / @BackgroundOnly marker annotations - #12471
Draft
dougqh wants to merge 1 commit into
Draft
Conversation
Documentation-and-tooling markers declaring whether code is cheap enough for application (foreground) threads or must be confined to a background thread the tracer paces itself. No application to real code yet and no checker -- just the annotation types, following the Strategy/StrategyConsumer marker convention (APMLP-1543).
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ForegroundSafeand@BackgroundOnly(datadog.trace.api.function), that declare whether code is cheap enough to run on application (foreground) threads or must be confined to a background thread.@ForegroundSafeis the strictly stronger guarantee — safe from either thread context;@BackgroundOnlymust never be reached from a foreground call site.SOURCEretention, no runtime behavior change. No annotation of real call sites and no checker yet — those are tracked separately (APMLP-1544, APMLP-1546).Implements APMLP-1543, laying groundwork for annotation-checking support in the
/perf-reviewskill (APMLP-1513).Test plan
techdebtreview: no issues (pure marker annotations, no duplication/dead code).perf-reviewreview: no findings (SOURCE-retention, zero runtime footprint)../gradlew spotlessCheck/:internal-api:spotbugsMain🤖 Generated with Claude Code