Support Robolectric 4.17 test metadata - #12478
AlexeyKuznetsov-DD wants to merge 9 commits into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: c57fe3f | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
The new codename mapping changes API 25, 27, and 32 to N, O, and S. The old values are NMR1, OMR1, and Sv2.
🤖 Datadog Autotest · Commit c2221fc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
daniel-mohedano
left a comment
There was a problem hiding this comment.
Changed the approach for the codename resolution, but overall LGTM! I also added a smoke test case so that we also test the latest version instead of just a fixed one. Thanks for taking the initiative of creating the PR with the fixes 🚀
CI Visibility Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - pass4sJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - heliboardJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - okhttpJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
alexey.kuznetsov@datadoghq.com unqueued this merge request |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
What Does This Do
android.os.Build.Motivation
Robolectric 4.17 removed
org.robolectric.versioning.AndroidVersions. Because the instrumentation's muzzle range is open-ended, validation began resolving 4.17 and failed deterministically:Using the Android SDK classes that Robolectric exposes avoids the removed internal API while preserving the existing CI Visibility metadata values.
Additional Notes
Validation:
./gradlew :dd-java-agent:instrumentation:robolectric-4.13:muzzle :dd-java-agent:instrumentation:robolectric-4.13:spotlessCheck./gradlew :dd-smoke-tests:gradle:spotlessCheck./gradlew :dd-smoke-tests:gradle:test --tests datadog.smoketest.GradleDaemonSmokeTest.testRobolectric(the existing JDK 17-21 guard skipped the scenario on JDK 25)Relevant precedent: #11852
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A