Skip to content

Support Robolectric 4.17 test metadata - #12478

Open
AlexeyKuznetsov-DD wants to merge 9 commits into
masterfrom
alexeyk/fix-robolectric-4-17-muzzle
Open

AlexeyKuznetsov-DD wants to merge 9 commits into
masterfrom
alexeyk/fix-robolectric-4-17-muzzle

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

  • Updates Robolectric test metadata collection for Robolectric 4.17 by reading the Android release and API level from android.os.Build.
  • Adds the Robolectric Android 14 SDK artifact as a compile-time and muzzle dependency.
  • Updates the Gradle daemon smoke fixture and expected events to test the pinned 4.16 version and the latest one (4.17).

Motivation

Robolectric 4.17 removed org.robolectric.versioning.AndroidVersions. Because the instrumentation's muzzle range is open-ended, validation began resolving 4.17 and failed deterministically:

FAILED MUZZLE VALIDATION: RobolectricInstrumentation mismatches:
-- RobolectricTestAnnotator: Missing class org.robolectric.versioning.AndroidVersions

Using the Android SDK classes that Robolectric exposes avoids the removed internal API while preserving the existing CI Visibility metadata values.

Additional Notes

Validation:

  • ./gradlew :dd-java-agent:instrumentation:robolectric-4.13:muzzle :dd-java-agent:instrumentation:robolectric-4.13:spotlessCheck
  • ./gradlew :dd-smoke-tests:gradle:spotlessCheck
  • ./gradlew :dd-smoke-tests:gradle:test --tests datadog.smoketest.GradleDaemonSmokeTest.testRobolectric (the existing JDK 17-21 guard skipped the scenario on JDK 25)

Relevant precedent: #11852

Contributor Checklist

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM labels Sep 13, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 69.74% (+10.70%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c57fe3f | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.66 s [+0.3%; +1.9%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.64 s 13.65 s [-0.9%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 17.01 s 16.32 s [-0.3%; +8.8%] (no difference)
startup:petclinic:iast:Agent 16.99 s 17.02 s [-1.0%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.55 s 16.86 s [-2.8%; -0.9%] (maybe better)
startup:petclinic:sca:Agent 16.98 s 16.74 s [+0.5%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.10 s 16.11 s [-1.2%; +0.9%] (no difference)

Commit: c57fe3f8 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review September 13, 2026 03:14
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners September 13, 2026 03:14
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from amarziali and ygree and removed request for a team September 13, 2026 03:14
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T03:16:38.805981Z c2221fc Draft marked ready
🔒 Security Review Completed 2026-09-13T03:17:51.398558Z c2221fc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The new codename mapping changes API 25, 27, and 32 to N, O, and S. The old values are NMR1, OMR1, and Sv2.

Open Bits AI session

🤖 Datadog Autotest · Commit c2221fc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@daniel-mohedano daniel-mohedano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the approach for the codename resolution, but overall LGTM! I also added a smoke test case so that we also test the latest version instead of just a fixed one. Thanks for taking the initiative of creating the PR with the fixes 🚀

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 53.17 55.43 $\color{green}{\blacktriangledown}$ -2.26 55.43 $\color{green}{\blacktriangledown}$ -2.26 48/192
agentEvpProxy 54.10 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@DataDog DataDog deleted a comment from cit-pr-commenter-54b7da Bot Sep 14, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 36.00 36.42 $\color{green}{\blacktriangledown}$ -0.42 36.42 $\color{green}{\blacktriangledown}$ -0.42 30/103
agentless 35.20 35.70 $\color{green}{\blacktriangledown}$ -0.50 35.70 $\color{green}{\blacktriangledown}$ -0.50 30/103
agentlessCodeCoverage 43.37 44.48 $\color{green}{\blacktriangledown}$ -1.11 44.48 $\color{green}{\blacktriangledown}$ -1.11 30/103
agentlessLineCoverage 54.51 55.43 $\color{green}{\blacktriangledown}$ -0.92 55.43 $\color{green}{\blacktriangledown}$ -0.92 30/103

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 87.57 87.80 $\color{green}{\blacktriangledown}$ -0.23 87.80 $\color{green}{\blacktriangledown}$ -0.23 29/101
agentless 82.05 81.05 $\color{red}{\blacktriangle}$ +1.00 81.05 $\color{red}{\blacktriangle}$ +1.00 28/100
agentlessCodeCoverage 95.01 95.12 $\color{green}{\blacktriangledown}$ -0.11 95.12 $\color{green}{\blacktriangledown}$ -0.11 28/100
agentlessLineCoverage 110.34 111.62 $\color{green}{\blacktriangledown}$ -1.28 111.62 $\color{green}{\blacktriangledown}$ -1.28 28/103

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 8.33 9.73 $\color{green}{\blacktriangledown}$ -1.40 9.92 $\color{green}{\blacktriangledown}$ -1.59 24/89
agentless 8.94 9.35 $\color{green}{\blacktriangledown}$ -0.41 9.73 $\color{green}{\blacktriangledown}$ -0.79 24/89
agentlessCodeCoverage 19.02 17.03 $\color{red}{\blacktriangle}$ +1.99 16.04 $\color{red}{\blacktriangle}$ +2.98 20/83

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 22.73 21.65 $\color{red}{\blacktriangle}$ +1.08 21.65 $\color{red}{\blacktriangle}$ +1.08 38/116
agentless 20.59 19.20 $\color{red}{\blacktriangle}$ +1.39 19.20 $\color{red}{\blacktriangle}$ +1.39 32/107
agentlessCodeCoverage 21.32 19.59 $\color{red}{\blacktriangle}$ +1.73 19.99 $\color{red}{\blacktriangle}$ +1.33 32/105
agentlessLineCoverage 28.81 26.98 $\color{red}{\blacktriangle}$ +1.83 26.98 $\color{red}{\blacktriangle}$ +1.83 20/61

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 11.07 10.13 $\color{red}{\blacktriangle}$ +0.94 10.13 $\color{red}{\blacktriangle}$ +0.94 27/98

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 11.49 12.62 $\color{green}{\blacktriangledown}$ -1.13 12.87 $\color{green}{\blacktriangledown}$ -1.38 37/105
agentless 11.57 11.65 $\color{green}{\blacktriangledown}$ -0.08 11.88 $\color{green}{\blacktriangledown}$ -0.31 30/98
agentlessCodeCoverage 15.47 14.81 $\color{red}{\blacktriangle}$ +0.66 15.11 $\color{red}{\blacktriangle}$ +0.36 30/98
agentlessLineCoverage 16.26 17.73 $\color{green}{\blacktriangledown}$ -1.47 17.73 $\color{green}{\blacktriangledown}$ -1.47 31/99

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 94.61 93.23 $\color{red}{\blacktriangle}$ +1.38 95.12 $\color{green}{\blacktriangledown}$ -0.51 33/112
agentless 90.37 89.58 $\color{red}{\blacktriangle}$ +0.79 89.58 $\color{red}{\blacktriangle}$ +0.79 32/110
agentlessCodeCoverage 99.03 99.00 $\color{red}{\blacktriangle}$ +0.03 99.00 $\color{red}{\blacktriangle}$ +0.03 32/108
agentlessLineCoverage 100.54 99.00 $\color{red}{\blacktriangle}$ +1.54 99.00 $\color{red}{\blacktriangle}$ +1.54 33/112

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 21.01 19.99 $\color{red}{\blacktriangle}$ +1.02 19.99 $\color{red}{\blacktriangle}$ +1.02 26/97
agentless 20.19 19.20 $\color{red}{\blacktriangle}$ +0.99 19.20 $\color{red}{\blacktriangle}$ +0.99 27/96
agentlessCodeCoverage 22.94 22.54 $\color{red}{\blacktriangle}$ +0.40 22.54 $\color{red}{\blacktriangle}$ +0.40 26/96
agentlessLineCoverage 38.64 38.67 $\color{green}{\blacktriangledown}$ -0.03 38.67 $\color{green}{\blacktriangledown}$ -0.03 27/98

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 15.89 16.04 $\color{green}{\blacktriangledown}$ -0.15 16.36 $\color{green}{\blacktriangledown}$ -0.47 30/99
agentless 10.41 9.73 $\color{red}{\blacktriangle}$ +0.68 9.92 $\color{red}{\blacktriangle}$ +0.49 28/97
agentlessCodeCoverage 13.41 13.40 $\color{red}{\blacktriangle}$ +0.01 13.40 $\color{red}{\blacktriangle}$ +0.01 28/97
agentlessLineCoverage 22.12 22.09 $\color{red}{\blacktriangle}$ +0.03 22.09 $\color{red}{\blacktriangle}$ +0.03 27/95

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 14, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 8.33 9.54 $\color{green}{\blacktriangledown}$ -1.21 10.97 $\color{green}{\blacktriangledown}$ -2.64 32/110
agentless 6.61 6.65 $\color{green}{\blacktriangledown}$ -0.04 8.98 $\color{green}{\blacktriangledown}$ -2.37 32/110
agentlessCodeCoverage 96.73 74.82 $\color{red}{\blacktriangle}$ +21.91 74.82 $\color{red}{\blacktriangle}$ +21.91 32/110
agentlessLineCoverage 95.29 111.62 $\color{green}{\blacktriangledown}$ -16.33 111.62 $\color{green}{\blacktriangledown}$ -16.33 32/108

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-14 15:28:13 UTC ℹ️ Start processing command /merge


2026-09-14 15:28:23 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-14 15:29:19 UTC ⚠️ MergeQueue: This merge request was unqueued

alexey.kuznetsov@datadoghq.com unqueued this merge request

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-14 15:29:13 UTC ℹ️ Start processing command /merge -c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants