[DBMON-6861] Fix stale azure field name and spec link in SQL Server setup docs - #38494
Draft
pierreln-dd wants to merge 1 commit into
Draft
[DBMON-6861] Fix stale azure field name and spec link in SQL Server setup docs#38494pierreln-dd wants to merge 1 commit into
pierreln-dd wants to merge 1 commit into
Conversation
…etup docs Replace leftover `name` field references with `fully_qualified_domain_name` in code samples and prose across all Azure SQL Server setup tabs, and update the integration spec permalink to the current line range.
Contributor
Preview links (active after the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Fixes DBMON-6861
The Azure SQL Server setup page mixed up the
azureblock's field name: several code samples and prose sentences referenced anamefield that doesn't exist in the integration spec, while the actual field isfully_qualified_domain_name. This page also linked to a specific line range in the integration spec on GitHub that no longer matches the current file.This PR:
"name"key with"fully_qualified_domain_name"in the Docker configuration JSON sampledeployment_typeandnamefields" sentences to referencefully_qualified_domain_nameazureconfig blockMerge instructions
Merge readiness:
Additional notes