v0.12.2#160
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa691399b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let has_spans = !spans_vec.is_empty(); | ||
| *self.prepared_spans.borrow_mut() = Some(spans_vec); | ||
| if has_spans { | ||
| self.prepared_spans.borrow_mut().push(spans_vec); |
There was a problem hiding this comment.
With the new push, staged chunks survive until sendPreparedChunk takes them, so if the host prepares a flush but intentionally skips the send (for example because another send is still in flight/back-pressure), the next flush appends to those abandoned chunks. A later sendPreparedChunk will send old traces together with the new batch, and sustained skipped sends can grow this Vec without bound; previously each new prepareChunk recycled the unsent chunk before staging the next one. Add an explicit batch reset/start marker or clear abandoned chunks before accumulating a new flush.
Useful? React with 👍 / 👎.
Overall package sizeSelf size: 30.08 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
2 participants
v0.12.2
Patch release cherry-picking #159 onto
v0.x.prepareChunknow accumulates one chunk per trace instead of overwriting;sendPreparedChunksends them together as one multi-trace request. Fixes trace mis-grouping and dropped sampling tags when the exporter batches multiple traces into one flush under load.No API changes. Unblocks the paired dd-trace-js exporter change (group-by-trace).