feat(stats)!: implement additional metric tags in libdd-trace-stats by duncanpharvey · Pull Request #2170 · DataDog/libdatadog

duncanpharvey · 2026-06-26T19:06:02Z

What does this PR do?

Add additional metric tags to the stats aggregation key. For each configured key, the matching span meta tag is included in the key and populates ClientGroupedStats.additional_metric_tags.
Limit the number of keys for additional_metric_tags to 4, not configurable.
Limit the maximum length of individual additional_metric_tags values to 200 characters, not configurable. Values exceeding this are replaced with tracer_blocked_value.

Motivation

Allow Serverless Compatibility Layer to send additional metric tags on trace stats. See RFC.
feat: implement additional metric tags for trace stats serverless-components#140 to follow.
https://datadoghq.atlassian.net/browse/SVLS-8787

Additional Notes

Additional metric tags still need to be implemented in libdd-data-pipeline. Omitted from this PR since the goal of this PR is to support additional metric tags tags for Serverless without affecting other teams.

libdatadog/libdd-data-pipeline/src/trace_exporter/stats.rs

Line 146 in 42e3296

vec![],

Per-field cardinality limit for additional metric tags will be implemented in a following PR, #2211.

Limit the number of distinct aggregation entries per bucket that carry additional metric tags to 100 by default, configurable via additional_metric_tags_max_entries. Once exceeded, new entries have their tag values masked to tracer_blocked_value.

Implementing additional metric tags instead of span derived primary tags. See previous PR for span derived primary tags - #1815.

How to test the change?

Unit tests
Deploy to Azure Functions with the following environment variables and validate that additional tags appear on trace metrics
- DD_TAGS: custom.primary:val,workload:azure_functions
- DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED: true
- DD_TRACE_STATS_ADDITIONAL_TAGS: custom.primary,workload

datadog-datadog-prod-us1-2 · 2026-06-26T19:06:55Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 96.86%
• Overall Coverage: 74.59% (-0.16%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: b6ac861 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-06-29T15:54:02Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.88 MB	7.88 MB	+0% (+48 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	86.16 MB	86.30 MB	+.16% (+148.01 KB) 🔍

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.62 MB	10.62 MB	+.02% (+3.21 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	97.41 MB	97.56 MB	+.14% (+146.68 KB) 🔍

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	25.55 MB	25.59 MB	+.17% (+46.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	88.85 KB	88.85 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	185.33 MB	185.55 MB	+.12% (+232.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	957.28 MB	958.61 MB	+.13% (+1.33 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	8.36 MB	8.37 MB	+.18% (+16.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	88.85 KB	88.85 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	24.73 MB	24.76 MB	+.15% (+40.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	49.23 MB	49.30 MB	+.13% (+70.16 KB) 🔍

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	22.20 MB	22.24 MB	+.18% (+42.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	90.24 KB	90.24 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	189.78 MB	190.02 MB	+.12% (+248.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	945.96 MB	946.68 MB	+.07% (+738.37 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.46 MB	6.47 MB	+.16% (+11.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	90.24 KB	90.24 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	26.55 MB	26.60 MB	+.20% (+56.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	46.84 MB	46.90 MB	+.14% (+67.99 KB) 🔍

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	76.98 MB	77.10 MB	+.15% (+121.60 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.81 MB	8.82 MB	+.08% (+8.06 KB) 🔍

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	92.39 MB	92.51 MB	+.12% (+121.62 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.72 MB	10.74 MB	+.13% (+14.41 KB) 🔍

# What does this PR do? - Update protobufs to be in sync with datadog-agent * `containerDebug` * `additional_metric_tags` - Update `DATADOG_AGENT_TAG` for protobufs comparison to DataDog/datadog-agent@fdc29d4 # Motivation Out of sync protobufs with datadog-agent. Needed for #2170. # Additional Notes <img width="788" height="301" alt="Screenshot 2026-06-29 at 3 03 21 PM" src="https://github.com/user-attachments/assets/ac605731-2338-4919-a078-1cb31de9b2d0" /> # How to test the change? - Weekly test to compare protobufs to main: https://github.com/DataDog/libdatadog/actions/workflows/weekly-verify-proto-files.yml - Per PR test to compare protobugs to specified commit: https://github.com/DataDog/libdatadog/actions/workflows/verify-proto-files.yml Co-authored-by: duncan.harvey <duncan.harvey@datadoghq.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42e3296aa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# What does this PR do? - Update protobufs to be in sync with datadog-agent * `containerDebug` * `additional_metric_tags` - Update `DATADOG_AGENT_TAG` for protobufs comparison to DataDog/datadog-agent@fdc29d4 # Motivation Out of sync protobufs with datadog-agent. Needed for #2170. # Additional Notes <img width="788" height="301" alt="Screenshot 2026-06-29 at 3 03 21 PM" src="https://github.com/user-attachments/assets/ac605731-2338-4919-a078-1cb31de9b2d0" /> # How to test the change? - Weekly test to compare protobufs to main: https://github.com/DataDog/libdatadog/actions/workflows/weekly-verify-proto-files.yml - Per PR test to compare protobugs to specified commit: https://github.com/DataDog/libdatadog/actions/workflows/verify-proto-files.yml Co-authored-by: duncan.harvey <duncan.harvey@datadoghq.com> Signed-off-by: Taegyun Kim <taegyun.kim@datadoghq.com>

#2170

…VALUE_MAX_LEN

…ries

pr-commenter · 2026-07-15T16:45:30Z

Benchmarks

Comparison

Benchmark execution time: 2026-07-21 19:14:13

Comparing candidate commit b6ac861 in PR branch duncan-harvey/libdd-trace-stats-additional-metric-tags with baseline commit 8892d38 in branch main.

Found 16 performance improvements and 6 performance regressions! Performance is the same for 119 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:otlp/e2e_json/1x1000

🟩 execution_time [-327.543µs; -317.245µs] or [-7.520%; -7.284%]

scenario:otlp/encode_json/1x1000

🟩 execution_time [-310.262µs; -309.768µs] or [-15.325%; -15.301%]

scenario:sql/obfuscate_sql_string

🟩 execution_time [-20.607µs; -20.349µs] or [-6.664%; -6.581%]

scenario:vec_map/as_deduped_map/already_deduped/8

🟩 execution_time [-0.607ns; -0.599ns] or [-4.194%; -4.135%]

scenario:vec_map/get_hit/128

🟩 execution_time [-2.873µs; -2.864µs] or [-17.330%; -17.277%]
🟩 throughput [+1613014.716op/s; +1618083.658op/s] or [+20.892%; +20.957%]

scenario:vec_map/get_hit/16

🟩 execution_time [-14.243ns; -13.948ns] or [-5.695%; -5.577%]
🟩 throughput [+3780588.720op/s; +3863148.009op/s] or [+5.909%; +6.038%]

scenario:vec_map/get_hit/64

🟩 execution_time [-740.217ns; -736.603ns] or [-16.668%; -16.587%]
🟩 throughput [+2866943.967op/s; +2881296.809op/s] or [+19.894%; +19.993%]

scenario:vec_map/get_mut/128

🟥 execution_time [+1.789µs; +1.903µs] or [+12.691%; +13.501%]
🟥 throughput [-1082172.371op/s; -1018612.490op/s] or [-11.916%; -11.216%]

scenario:vec_map/get_mut/16

🟥 execution_time [+29.003ns; +39.274ns] or [+10.649%; +14.420%]
🟥 throughput [-7619867.362op/s; -5559704.481op/s] or [-12.864%; -9.386%]

scenario:vec_map/get_mut/64

🟥 execution_time [+378.268ns; +415.269ns] or [+9.704%; +10.653%]
🟥 throughput [-1591135.992op/s; -1446197.377op/s] or [-9.686%; -8.804%]

scenario:vec_map/iter/128

🟩 execution_time [-6.579ns; -6.407ns] or [-5.912%; -5.758%]
🟩 throughput [+70404614.077op/s; +72093834.186op/s] or [+6.120%; +6.267%]

scenario:vec_map/iter/16

🟩 execution_time [-0.575ns; -0.566ns] or [-4.209%; -4.138%]
🟩 throughput [+50533201.361op/s; +51427924.228op/s] or [+4.317%; +4.394%]

scenario:vec_map/iter/8

🟩 execution_time [-0.598ns; -0.590ns] or [-8.259%; -8.152%]
🟩 throughput [+98137860.394op/s; +99528651.571op/s] or [+8.878%; +9.004%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

…the spec

VianneyRuhlmann · 2026-07-21T15:56:25Z

+#[test]
+fn test_additional_metric_tag_value_multibyte_over_length_cap_substitutes_blocked_value() {
+    // 201 two-byte characters exceeds the 200-character cap even though earlier bytes-based
+    // checks would have let a 201-char, sub-200-byte value like this through incorrectly.


Nit: This comment is confusing, it seems to be referring to a test that was removed.

Addressed in b6ac861.

duncanpharvey · 2026-07-21T19:11:25Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-21T19:11:29Z

View all feedbacks in Devflow UI.

2026-07-21 19:11:29 UTC ℹ️ Start processing command /merge

2026-07-21 19:11:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-07-21 19:23:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-07-21 20:04:14 UTC ℹ️ MergeQueue: This merge request was merged

…n metric (#2264) ## What does this PR do? #2170 added `additional_metric_tags` to `ClientGroupedStats` in `libdd-trace-stats`, letting tracers attach extra tracer/customer-configured key/value dimensions (up to 4 keys, values capped at 200 chars) to stats aggregation. That change only wired the tags into the native `/v0.6/stats` agent payload. This PR extends the OTLP stats path (`libdd-data-pipeline/src/otlp/metrics.rs`) so the same `additional_metric_tags` are also serialized as data-point attributes on the `traces.span.sdk.metrics.duration` OTLP histogram metric, mirroring the existing `peer_tags` handling. ## Motivation Consumers of the OTLP metrics export (e.g. via an OTel collector) were silently missing these additional tags/dimensions that are already present in the native stats payload, creating a parity gap between the two export paths. ## Additional Notes - These tags are user/tracer-defined (not Datadog-internal), so — like `peer_tags` — they are emitted in both normal and `otel_trace_semantics_enabled` (OTel-semantics) mode; they're not stripped like `datadog.*` attributes. - `additional_metric_tags` entries are `"key:value"` strings; splitting on the first `:` (not `split(':')`/last) correctly preserves values containing embedded colons (e.g. URLs), matching how `peer_tags` are handled. ## How to test the change? - Added `emits_additional_metric_tags_as_attributes` unit test in `libdd-data-pipeline/src/otlp/metrics.rs` covering: normal emission, values containing embedded colons, pass-through under `otel_trace_semantics_enabled`, and skipping malformed/empty-value entries. - `cargo nextest run -p libdd-data-pipeline` and `cargo +stable clippy -p libdd-data-pipeline --all-targets -- -D warnings` pass locally. Co-authored-by: munir.abdinur <munir.abdinur@datadoghq.com>

…er-flare (#2332) # Release proposal for libdd-ffe, libdd-http-client, libdd-tracer-flare and their dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-v3.0.0` ### Commits - fix(telemetry)!: stop sending Connection: close to the Agent (#2286) - feat(capabilities)!: Add streaming to http capabilities (#2251) - feat: added file capability [APMSP-3780] (#2240) - feat: added environment capability [APMSP-3780] (#2239) ## libdd-common **Next version:** `5.1.1` **Semver bump:** `patch` **Tag:** `libdd-common-v5.1.1` ### Commits - feat(telemetry)!: Add Installation signature and AppProduct changes payloads (#2213) - refactor: migrate to workspace dependencies, phase 4 (#2296) - refactor: migrate to workspace dependencies, phase 3 (#2283) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) - test: stabilize flaky tests (#2256) - fix(sidecar): don't double-encode file:// telemetry endpoints (#2230) - fix: last new clippy lint (#2221) ## libdd-tinybytes **Next version:** `1.1.2` **Semver bump:** `patch` **Tag:** `libdd-tinybytes-v1.1.2` ### Commits - chore: moving to workspace-level dependencies, phase 2 (#2270) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) ## libdd-trace-protobuf **Next version:** `4.0.1` **Semver bump:** `patch` **Tag:** `libdd-trace-protobuf-v4.0.1` ### Commits - refactor: migrate to workspace dependencies, phase 4 (#2296) - chore: moving to workspace-level dependencies, phase 2 (#2270) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) - feat(stats)!: implement additional metric tags in libdd-trace-stats (#2170) ## libdd-capabilities-impl **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v4.0.0` ### ⚠️ major bump forced due to: - `libdd-capabilities`: ^2.1.0 → ^3.0.0 ### Commits - feat(telemetry)!: Add Installation signature and AppProduct changes payloads (#2213) - refactor: migrate to workspace dependencies, phase 4 (#2296) - fix(telemetry)!: stop sending Connection: close to the Agent (#2286) - fix(remote-config)!: Expose HttpClientCapability in remote config (#2252) - feat(capabilities)!: Add streaming to http capabilities (#2251) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) - feat: added file capability [APMSP-3780] (#2240) - feat(telemetry)!: make telemetry worker wasm-compatible for the TraceExporter (#2172) - feat: added environment capability [APMSP-3780] (#2239) ## libdd-http-client **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-http-client-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-trace-normalization **Next version:** `3.0.1` **Semver bump:** `patch` **Tag:** `libdd-trace-normalization-v3.0.1` ### Commits - refactor: migrate to workspace dependencies, phase 4 (#2296) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) ## libdd-remote-config **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-remote-config-v3.0.0` ### Commits - refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available (#2325) - fix(wasm)!: finish the WASM port of remote-config (#2315) - refactor: migrate to workspace dependencies, phase 3 (#2283) - feat(rc): Handle expired config status (#2274) - feat(remote-config)!: add AsmRawResponseBody capability (#2278) - chore: moving to workspace-level dependencies, phase 2 (#2270) - fix(remote-config)!: Expose HttpClientCapability in remote config (#2252) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) - fix(rc): Make Target fields available again after eaf5ad0 (#2232) - fix: new clippy lints (#2219) ## libdd-trace-utils **Next version:** `10.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-utils-v10.0.0` ### ⚠️ major bump forced due to: - `libdd-capabilities`: ^2.1.0 → ^3.0.0 ### Commits - refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available (#2325) - fix(libdd-trace-utils): apply SpanLink flags masking when v0.5 json encoding (#2314) - refactor: migrate to workspace dependencies, phase 4 (#2296) - feat(data-pipeline)!: add compression option for agentless export (#2205) - refactor: migrate to workspace dependencies, phase 3 (#2283) - refactor(trace-utils)!: split generic TracerHeaderTags (#2279) - chore(lint): update nightly (#2281) - chore: moving to workspace-level dependencies, phase 2 (#2270) - fix(remote-config)!: Expose HttpClientCapability in remote config (#2252) - refactor: consolidate core dependencies at workspace level (phase 1) (#2253) - feat(stats)!: implement additional metric tags in libdd-trace-stats (#2170) - feat(trace-utils)!: add v1 decoder (#2174) - feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145) - feat(otlp): add instrumentation scope metadata (#2235) - fix(trace-utils)!: serialize v0.5 span links and events into meta (#980) ## libdd-ffe **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-ffe-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-tracer-flare **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-tracer-flare-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. [APMSP-3780]: https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [APMSP-3780]: https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [APMSP-3780]: https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>

github-actions Bot added the data-pipeline label Jun 26, 2026

duncanpharvey mentioned this pull request Jun 26, 2026

feat(stats)!: implement span derived primary tags in libdd-trace-stats #1815

Closed

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch 2 times, most recently from c020593 to 82959f7 Compare June 29, 2026 14:47

github-actions Bot added ci-build mini-agent labels Jun 29, 2026

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from 82959f7 to 9977516 Compare June 29, 2026 15:13

duncanpharvey mentioned this pull request Jun 29, 2026

feat: implement additional metric tags for trace stats DataDog/serverless-components#140

Open

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from fb6b20d to b3d13e5 Compare June 29, 2026 16:02

duncanpharvey mentioned this pull request Jun 30, 2026

chore!: update protobufs to be in sync with datadog-agent #2180

Merged

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from b3d13e5 to def0a56 Compare July 6, 2026 16:47

github-actions Bot removed the ci-build label Jul 6, 2026

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from def0a56 to 42e3296 Compare July 6, 2026 18:13

duncanpharvey marked this pull request as ready for review July 6, 2026 19:51

duncanpharvey requested review from a team as code owners July 6, 2026 19:51

duncanpharvey requested review from a team, apiarian-datadog and lucaspimentel and removed request for a team July 6, 2026 19:52

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread libdd-data-pipeline/src/trace_exporter/stats.rs

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs Outdated

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from 42e3296 to a7a73a5 Compare July 6, 2026 20:47

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

7e65d08

#2170

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

08652b2

#2170

Eldolfin added a commit that referenced this pull request Jul 10, 2026

fix: link span derived primary tags ticket and pr

edf1e0c

#2170

Eldolfin reviewed Jul 13, 2026

View reviewed changes

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs Outdated

duncanpharvey added 4 commits July 14, 2026 15:05

implement additional_metric_tags in libdd-trace-stats

f0b74ea

use character limit rather than byte limit for ADDITIONAL_METRIC_TAG_…

86774a7

…VALUE_MAX_LEN

apply formatting

f053f70

remove per field cardinality limits in additional_metric_tags_max_ent…

143f090

…ries

duncanpharvey force-pushed the duncan-harvey/libdd-trace-stats-additional-metric-tags branch from a7a73a5 to 143f090 Compare July 15, 2026 16:10

fix tests

8280c19

Eldolfin reviewed Jul 15, 2026

View reviewed changes

Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs Outdated

improve performance of character count check while still adhering to …

f52187f

…the spec

Eldolfin approved these changes Jul 21, 2026

View reviewed changes

VianneyRuhlmann approved these changes Jul 21, 2026

View reviewed changes

clean up test comments

b6ac861

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jul 21, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 63ecad5 into main Jul 21, 2026
112 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Jul 21, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the duncan-harvey/libdd-trace-stats-additional-metric-tags branch July 21, 2026 20:04

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Jul 21, 2026

mabdinur mentioned this pull request Jul 22, 2026

feat(data-pipeline): emit additional_metric_tags on OTLP span duration metric #2264

Merged

dd-octo-sts Bot mentioned this pull request Jul 30, 2026

chore(release): proposal for libdd-http-client, libdd-tracer-flare #2299

Closed

dd-octo-sts Bot mentioned this pull request Aug 7, 2026

chore(release): proposal for libdd-ffe, libdd-http-client, libdd-tracer-flare #2332

Merged

Navigation Menu

Uh oh!

feat(stats)!: implement additional metric tags in libdd-trace-stats - #2170

feat(stats)!: implement additional metric tags in libdd-trace-stats#2170
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
mainfrom
duncan-harvey/libdd-trace-stats-additional-metric-tags

duncanpharvey commented Jun 26, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 •

edited by datadog-datadog-us1-prod Bot

Loading

Uh oh!

dd-octo-sts Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pr-commenter Bot commented Jul 15, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

Uh oh!

VianneyRuhlmann Jul 21, 2026

Uh oh!

duncanpharvey Jul 21, 2026

Uh oh!

duncanpharvey commented Jul 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

duncanpharvey commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 • edited by datadog-datadog-us1-prod Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pr-commenter Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Comparison

Explanation

More details about the CI and significant changes

scenario:otlp/e2e_json/1x1000

scenario:otlp/encode_json/1x1000

scenario:sql/obfuscate_sql_string

scenario:vec_map/as_deduped_map/already_deduped/8

scenario:vec_map/get_hit/128

scenario:vec_map/get_hit/16

scenario:vec_map/get_hit/64

scenario:vec_map/get_mut/128

scenario:vec_map/get_mut/16

scenario:vec_map/get_mut/64

scenario:vec_map/iter/128

scenario:vec_map/iter/16

scenario:vec_map/iter/8

Candidate

Baseline

Uh oh!

Uh oh!

VianneyRuhlmann Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey commented Jul 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

duncanpharvey commented Jun 26, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Jun 26, 2026 •

edited by datadog-datadog-us1-prod Bot

Loading

dd-octo-sts Bot commented Jun 29, 2026 •

edited

Loading

pr-commenter Bot commented Jul 15, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026 •

edited

Loading