refactor(trace-utils)!: split generic TracerHeaderTags - #2279
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 28, 2026
Conversation
…nericTags TracerHeaderTags mixed tracer-identity strings (lang, version, etc.) with generic bool/int flags (client_computed_stats, dropped_p0_traces, ...). The latter are meaningful independently of the string metadata, so pull them into a standalone TracerGenericTags struct that can be carried on its own where the string fields would be redundant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 7b79f50 | Docs | Datadog PR Page | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b79f50b18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bwoebi
changed the title
bwoebi
approved these changes
Jul 27, 2026
yannham
reviewed
Jul 27, 2026
VianneyRuhlmann
approved these changes
Jul 27, 2026
yannham
approved these changes
Jul 28, 2026
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Jul 28, 2026
79eff2f
into
main
152 of 158 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
anais/split-tracer-header-tags
branch
July 28, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Splits
TracerHeaderTagsinto two parts: the tracer-identity strings (lang,lang_version,tracer_version, etc.) stay as-is, and the generic bool/int flags (client_computed_stats,client_computed_top_level,dropped_p0_traces,dropped_p0_spans) are pulled into a new standaloneTracerGenericTagsstruct, embedded asTracerHeaderTags::generic.Motivation
TracerHeaderTagsmixed tracer-identity strings with generic bool/int flags. The latter are meaningful independently of the string metadata, so pulling them into their own struct lets them be carried on their own in contexts where the string fields would be redundant (e.g. payload formats that already embed the tracer identity), without forcing a full split of the type.Additional Notes
Raised during review of #2156. Prepared as a separate PR to keep #2156 scoped to the sidecar-specific V04→V1 changes.
This PR alone is a no-op refactor —
TracerGenericTagsis still only used embedded inTracerHeaderTags. The actual payoff comes in #2156: the V1 trace-sending path already carries the tracer identity in the V1 payload itself, sosend_trace_v1will be able to pass justTracerGenericTags(a smallCopystruct, no serialization needed) across the sidecar's IPC boundary instead of the fullTracerHeaderTags/SerializedTracerHeaderTags, which currently re-transmits redundant string data.