fix(parametric): wait for post-restart Node telemetry - #7464
Draft
bm1549 wants to merge 2 commits into
Draft
Conversation
Contributor
|
|
bm1549
force-pushed
the
brian.marks/fix-stale-telemetry-config-wait
branch
from
August 6, 2026 19:38
b1ef15c to
98cfc58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Read the illustrated problem and fix report (Datadog AppGate)
The Node.js stable configuration tests restarted the test app and then read any telemetry already held by the test agent. A pre-restart configuration could be checked before the new runtime sent its
app-startedpayload, making the assertion flaky.Changes
Capture the current Node runtime ID before restart and wait for a different
app-startedruntime afterward. Read configuration only from that runtime, then use the existing direct assertions and newest sequence for each setting.The regression tests cover a late post-restart runtime, a stale matching value from the old runtime, and a superseded configuration sequence.
Testing
./run.sh TEST_THE_TEST -q --disable-warnings --tb=no(381 passed, 1 xfailed)TEST_LIBRARY=nodejs ./run.sh PARAMETRIC --skip-parametric-build tests/parametric/test_config_consistency.py::Test_Stable_Config_Default::test_extended_configs(4 passed)./format.shWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
Contact the repository maintainers if help is needed.
Reviewer checklist
tests/ormanifests/is modified ? I have approval from the repository maintainers.build-XXX-imagelabel is present