fix: handle invalid language routes - #2820
Open
lynnedogwo wants to merge 1 commit into
Open
lynnedogwo wants to merge 1 commit into
lynnedogwo wants to merge 1 commit into
Conversation
|
@lynnedogwo is attempting to deploy a commit to the DeepSource Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an unhandled server error when a user visits a language route that does not exist.
Problem
When an invalid language slug is provided,
Tags.find()returnsundefined. The page then attempts to accesstag.language, causing a TypeError and returning an HTTP 500 response.Solution
Added a check to verify that the language tag exists. If no matching tag is found, the application now throws a Nuxt 404 error with the message "Language Not Found".
Testing
Verified locally:
/language/javascriptreturns HTTP 200 and renders correctly./language/nonexistentreturns HTTP 404 instead of HTTP 500.AI Disclosure
AI assistance was used to investigate the codebase, identify the root cause, and assist with the implementation. The change was reviewed and tested locally before submission.