Skip to content

allow users to choose viewed log - #174

Merged
yousefmoazzam merged 21 commits into
DiamondLightSource:mainfrom
fallars:Main2
Sep 15, 2026
Merged

yousefmoazzam merged 21 commits into
DiamondLightSource:mainfrom
fallars:Main2

Conversation

@fallars

@fallars fallars commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

updating the logging component to allow users to choose which workflow logs are displayed for. Currently limited to only successfull workflows.

…w logs are displayed for. Currently limited to only successfull workflows.
@fallars

fallars commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

I switched the jobsviewer to jobstable, as was having issues pass varibles multiple times, but also seem like now visits/(visit info) are defined on the app level. hope this is okay.

@NatLeung96 NatLeung96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the best things about typescript is that it has types. I strongly suggest that you use them and, most importantly of all, avoid using the any type like the plague. I think you've created more work for yourself because you are manually checking the type when the language can do that for you.

Comment thread frontend/unified/src/components/InspectLogMeta.tsx Outdated
Comment thread frontend/unified/src/App.tsx Outdated

@yousefmoazzam yousefmoazzam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

As mentioned in #174 (comment), we can tidy the nested if statements later when passing workflow info via job table row clicking is implemented.

@yousefmoazzam
yousefmoazzam dismissed NatLeung96’s stale review September 15, 2026 14:26

See #174 (comment) for information on further refactoring of the nested if statements once job table row clicking is implemented.

@yousefmoazzam
yousefmoazzam merged commit 6fcb981 into DiamondLightSource:main Sep 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants