Conversation
yousefmoazzam
left a comment
yousefmoazzam
left a comment
There was a problem hiding this comment.
Just a few unnecessary bits of code that can be removed I think, otherwise it looks good.
One thing we need to keep in mind is that the resource parameters were hardcoded in the top-level ParameterConfiguration component when I was developing for a single workflow template. Now that we have multiple workflow templates going through the ParameterConfiguration component, we'll need to pass a setter for the resourceParameters state to all the child param config components like we do for the templateParameters state.
But as long as this works for you locally to submit a job with the correct template parameters, that work can be deferred to a later PR.
| import { useEffect, useState } from "react"; | ||
| import { TemplateComponentProps } from "../../types"; | ||
|
|
||
| const HTTOMO_OUTDIR_NAME = "sweep-run"; |
There was a problem hiding this comment.
I think this is not needed and is probably leftover from copying code from TomoParameterConfiguration.tsx?
| import { | ||
| Card, | ||
| Stack, | ||
| Checkbox, | ||
| FormControlLabel, | ||
| FormGroup, | ||
| TextField, | ||
| Typography, | ||
| } from "@mui/material"; |
There was a problem hiding this comment.
I think there are some unused imports that can be removed.
2 participants
adding basic ptyrex component which uses workflows to submit a ptyrex reconstruction. this should correlate to using the following workflow:
workflows.diamond.ac.uk/templates/ptyrex-submission
See the screen shot of the component below
