Unified Refactor - #181
Draft
NatLeung96 wants to merge 27 commits into
Draft
Unified Refactor#181NatLeung96 wants to merge 27 commits into
NatLeung96 wants to merge 27 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can probably guess from the branch name, I went way off the rails with this one.
I've refactored the unified app so that it's more organised and should be easier to work with. This refactor should also now allow us to render things even if the session query fails (although I have cheated a bit with this PR so it will need proper attention in future).
The new SessionManager component still needs some work to properly update the current visit/session and beamline but I thought I would make this draft PR so you can at least start to have a look at it.