Change CLEM series name (tag) format - #897
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 55.07% 55.08%
=======================================
Files 103 103
Lines 11534 11532 -2
Branches 1531 1530 -1
=======================================
Hits 6352 6352
+ Misses 4839 4838 -1
+ Partials 343 342 -1 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR and DiamondLightSource/cryoem-services#315 need to be deployed together.
Previously, CLEM series names were constructed using the path parts with
--as the separator. This has proven to be insufficiently robust, as--is also used in the path parts. Switching over to/as the separator makes it more robust, and brings it more in line with how tags are constructed in the other instrument workflows currently supported by Murfey.