Crawl pvi screens - #272
Draft
tomkane-dls wants to merge 5 commits into
Draft
tomkane-dls wants to merge 5 commits into
tomkane-dls wants to merge 5 commits into
Conversation
tomkane-dls
force-pushed
the
crawl-pvi-screens
branch
from
September 22, 2026 11:00
e0385bd to
49aec7e
Compare
The test fetched a screen from a real beamline's opis server, which meant the hostname, IOC and PV prefix appeared in the test and the screens it crawled were not in the repo. Crawl the t01 motor IOC's index.bob instead: it is already checked in under tests/t01-services and links on to three sub-screens, so it covers the same behaviour without any new fixtures.
#273 moved WidgetType to utils.py; the crawl module and its tests were still reaching it through jsonmap.links, which only re-imports it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 96.55% 95.46% -1.10%
==========================================
Files 17 18 +1
Lines 1075 1147 +72
==========================================
+ Hits 1038 1095 +57
- Misses 37 52 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.