Hla 853 toggleable simulation parameters - #24
Merged
Merged
Conversation
ptsOSL
commented
Sep 21, 2026
ptsOSL
commented
Collaborator
- Allows disabling of emittance, chromaticity and radiation calculations. Also allows selection of linopt function
- Virtac prints what settings are in use at startup
Allow selecting linopt function, disabling chromaticity and disabling_radiation. Also update the Virtac print data.
We now use the SimParams dataclass from atip instead of storing the boolean args supplied from the CLI as seperate variables.
ptsOSL
force-pushed
the
hla-853-toggleable-simulation-parameters
branch
from
September 22, 2026 10:33
6e4427f to
7c9bc69
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 26.21% 26.39% +0.18%
==========================================
Files 5 5
Lines 599 610 +11
==========================================
+ Hits 157 161 +4
- Misses 442 449 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MJGaughran
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.