Quote list_values=False values that would not survive a reload - #279
Open
abhijeet117 wants to merge 1 commit into
Open
Quote list_values=False values that would not survive a reload#279abhijeet117 wants to merge 1 commit into
abhijeet117 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
list_values=False, a value containing#was written bare and everything from the#was silently dropped as an inline comment on reload. A value starting with a quote character was written bare and could not be parsed at all on reload. Both broke the round trip of configobj's own output. Such values are now quoted on write and unquoted symmetrically on read; ambiguous quoted lines keep their verbatim text.Fixes #270
Testing
Reproduced both failures from issue #270 before changing code:
hello # worldreloaded ashello, andhello worldraised a parse error. Addedtest_list_values_false_written_output_can_be_read_back, which fails on master and passes here. Full suite passes except one pre-existing Windows-only line-ending failure; doctests andpython -m configobj.validatepass too.Checklist