Skip to content

ENG-2146 Bulk-Convert some db structures to CrossApp structures as needed for relation discovery - #1300

Merged
maparent merged 2 commits into
mainfrom
eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as
Aug 21, 2026
Merged

ENG-2146 Bulk-Convert some db structures to CrossApp structures as needed for relation discovery#1300
maparent merged 2 commits into
mainfrom
eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as

Conversation

@maparent

@maparent maparent commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

@linear-code

linear-code Bot commented Aug 17, 2026

Copy link
Copy Markdown

ENG-2146

@supabase

supabase Bot commented Aug 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
discourse-graph Ready Ready Preview Aug 21, 2026 12:49pm

Request Review

@maparent
maparent force-pushed the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch from 695f050 to e1f50d9 Compare August 19, 2026 13:51
@maparent
maparent marked this pull request as ready for review August 19, 2026 13:51
@graphite-app

graphite-app Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/database/src/lib/dbToCrossAppConverters.ts
Comment thread packages/database/src/lib/dbToCrossAppConverters.ts Outdated
@maparent
maparent force-pushed the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch 2 times, most recently from 869fd7f to dd453d9 Compare August 19, 2026 14:24
@maparent
maparent requested a review from mdroidian August 19, 2026 14:25
Base automatically changed from eng-2050-reintroduce-spaceId-in-crossapp-base to main August 19, 2026 16:33
@maparent
maparent force-pushed the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch from dd453d9 to e8820fb Compare August 19, 2026 16:34
@maparent
maparent force-pushed the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch from e8820fb to 34d0502 Compare August 21, 2026 12:42
@maparent
maparent force-pushed the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch from 34d0502 to dbd71ca Compare August 21, 2026 12:47
@maparent
maparent merged commit bd3cc53 into main Aug 21, 2026
11 checks passed
@maparent
maparent deleted the eng-2146-bulk-convert-some-db-structures-to-crossapp-structures-as branch August 21, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants