ENG-1867 Import cross-app relations into Roam as tentative relations - #1302
Open
maparent wants to merge 7 commits into
Hidden character warning
The head ref may contain hidden characters: "eng-1867-Import-cross-app\u2013relations-in-roam-as-tentative"
Open
ENG-1867 Import cross-app relations into Roam as tentative relations#1302maparent wants to merge 7 commits into
maparent wants to merge 7 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 17, 2026 22:37
452cc49 to
1928997
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 19, 2026 13:37
1928997 to
70f63a7
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 19, 2026 14:19
70f63a7 to
5ce9525
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 19, 2026 14:32
5ce9525 to
69aedbc
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 19, 2026 14:56
69aedbc to
9036ffd
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 19, 2026 16:33
9036ffd to
f4ef064
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 20, 2026 01:09
f4ef064 to
c3e095b
Compare
maparent
marked this pull request as ready for review
August 20, 2026 01:13
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 20, 2026 01:22
c3e095b to
b062e59
Compare
Base automatically changed from
eng-2145-utility-function-to-discover-importable-relations-and
to
main
August 21, 2026 13:04
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 21, 2026 13:05
f30f065 to
5276db1
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 00:37
03b13ed to
e8b609b
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 16:03
b0d1031 to
a360ea2
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 16:10
a360ea2 to
5f45a0d
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 16:29
5f45a0d to
6699f70
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 17:24
6699f70 to
84c96a5
Compare
maparent
force-pushed
the
eng-1867-Import-cross-app–relations-in-roam-as-tentative
branch
from
August 22, 2026 17:25
84c96a5 to
d0dcb0f
Compare
Collaborator
Author
|
Ok. Addressed most issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1867/import-cross-app-relations-into-roam-as-tentative-relations
Code walkthrough:
https://www.loom.com/share/e3cfe2ce63a34382a2b23200cb9e0b1e
Note: Since the code walkthrough I removed the RidToId in the discovery results.
Also added the correction to getDiscourseRelations, and code to delete an incorrect imported relation.
Simple demo:
https://www.loom.com/share/a0dd5ca98a194536a6d4350ec96b8bcb
Demo with type creation:
https://www.loom.com/share/bc8336651d7243f1b6f809ee6e886d9f
Quick note on templates
https://www.loom.com/share/5bfd0fffc27446af9d5d88383c7e276a