ENG-2127 Replace all arity checks in the code by is_relation checks - #1310
Merged
maparent merged 2 commits intoAug 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
from
August 19, 2026 14:37
9bedb80 to
8a65e7f
Compare
maparent
marked this pull request as ready for review
August 19, 2026 14:39
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mdroidian
approved these changes
Aug 19, 2026
mdroidian
left a comment
mdroidian
left a comment
Member
There was a problem hiding this comment.
- packages/database/doc/concept_design.md:126 still contains seven arity-based query examples and describes is_relation as a future proposal.
- packages/database/schema.yaml:336 still states that nodes have zero arity and omits is_relation.
- The corresponding PlantUML/SVG schema artifacts are consequently stale.
- concept_example.md remains factually valid, but adding is_relation and a positive-arity node would better demonstrate the new distinction.
maparent
force-pushed
the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
from
August 19, 2026 21:55
f669505 to
fc6fea3
Compare
maparent
force-pushed
the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
from
August 20, 2026 00:43
48db967 to
104f7c5
Compare
maparent
force-pushed
the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
from
August 20, 2026 17:32
104f7c5 to
26fd18e
Compare
Base automatically changed from
eng-2126-create-a-is_relation-computed-column-on-concept
to
main
August 21, 2026 12:39
maparent
force-pushed
the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
from
August 21, 2026 12:39
26fd18e to
42fd4f0
Compare
maparent
deleted the
eng-2127-replace-all-arity-checks-in-the-code-by-is_relation-checks
branch
August 21, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-2127/replace-all-arity-checks-in-the-code-by-is-relation-checks
https://www.loom.com/share/485cddd7c72a49eda740552c569e051f