-
Notifications
You must be signed in to change notification settings - Fork 7
ENG-2158 Publish node type format with schemas #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3ea0a1b
b8b6823
228ca57
1ad4e68
ca4b330
675a796
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ export type CrossAppNodeSchema = CrossAppSchemaBase & { | |
| label: string; | ||
| template?: string; | ||
| templateTitle?: string; | ||
| format?: string; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Flat |
||
| slotDefinitions?: Record<string, LocalId | undefined>; | ||
| }; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,7 @@ export const crossAppNodeSchemaToDbConcept = ( | |
| const literalInfo = filterUndefined({ | ||
| template: node.templateTitle, | ||
| template_content: node.template, | ||
| format: node.format, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The publish path writes only |
||
| roles: slots.length > 0 ? slots : undefined, | ||
| }); | ||
| const referenceContent = slots.length ? node.slotDefinitions : undefined; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DiscourseNode.formatis marked deprecated in favor ofspecification, but that deprecation is about node identification.formatis still the title pattern, and the title pattern is what ENG-2156 and ENG-2157 read from the schema row.