Fix prototype build tooling - #6
Merged
Merged
Conversation
mdroidian
marked this pull request as ready for review
August 17, 2026 02:36
Roam prototype previewsCI passed, but this branch does not contain an installable prototype yet. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3bdf4b47f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roam-prototypeCLI entry point through real filesystem paths so Windows workspace links execute correctlyrunExtensionutility export, avoiding a non-callable CommonJS wrapper at runtimeBuilt distProblems found during the stock prototype test
roam-prototype buildcould compare its linkedprocess.argv[1]path with the real module path, decide it was not the CLI entry point, and exit successfully without creatingdist/extension.js.roamjs-components/util/runExtensionbecame a CommonJS module object in the ESM bundle. Roam then failed withTypeError: (0, at.default) is not a function.--offlineoutside CI, so a developer without every tarball already cached failed ones-module-lexer.The missing artifact, silent artifact skip, and interrupted dependency state observed during the test were downstream symptoms of these issues rather than separate prototype defects.
Developer impact
New prototypes now build through the normal package script on linked Windows workspaces, load the generated lifecycle wrapper correctly in Roam, and can run the integration suite with a cold or partially populated pnpm cache.
Validation
pnpm test: 29 passedpnpm buildpnpm prepare:artifactsBuilt distand emits the public artifact contract