Skip to content

Fix prototype build tooling - #6

Merged
mdroidian merged 2 commits into
mainfrom
agent/fix-prototype-build-tooling
Aug 17, 2026
Merged

Fix prototype build tooling#6
mdroidian merged 2 commits into
mainfrom
agent/fix-prototype-build-tooling

Conversation

@mdroidian

Copy link
Copy Markdown
Member

Summary

  • resolve the shared roam-prototype CLI entry point through real filesystem paths so Windows workspace links execute correctly
  • generate starters with the named runExtension utility export, avoiding a non-callable CommonJS wrapper at runtime
  • prefer the pnpm cache during local integration tests while allowing missing packages to download
  • strengthen regressions so a generated build must report Built dist
  • add a linked-directory CLI execution test

Problems found during the stock prototype test

  1. Successful no-op build: On Windows, roam-prototype build could compare its linked process.argv[1] path with the real module path, decide it was not the CLI entry point, and exit successfully without creating dist/extension.js.
  2. Runtime load failure: The generated default import of roamjs-components/util/runExtension became a CommonJS module object in the ESM bundle. Roam then failed with TypeError: (0, at.default) is not a function.
  3. Cold-cache test failure: The starter integration test forced --offline outside CI, so a developer without every tarball already cached failed on es-module-lexer.

The missing artifact, silent artifact skip, and interrupted dependency state observed during the test were downstream symptoms of these issues rather than separate prototype defects.

Developer impact

New prototypes now build through the normal package script on linked Windows workspaces, load the generated lifecycle wrapper correctly in Roam, and can run the integration suite with a cold or partially populated pnpm cache.

Validation

  • targeted CLI and generator tests: 8 passed
  • pnpm test: 29 passed
  • pnpm build
  • pnpm prepare:artifacts
  • generated-starter integration test verifies the build reports Built dist and emits the public artifact contract

@mdroidian
mdroidian marked this pull request as ready for review August 17, 2026 02:36
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Roam prototype previews

CI passed, but this branch does not contain an installable prototype yet.

View publishing details

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3bdf4b47f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension-base/template/src/index.ts

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@mdroidian
mdroidian merged commit 7295ed9 into main Aug 17, 2026
1 check passed
@mdroidian
mdroidian deleted the agent/fix-prototype-build-tooling branch August 17, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant