Skip to content

Render raw prototype preview URLs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 1 commit into from
Aug 17, 2026
Merged

Render raw prototype preview URLs #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/comment-preview.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ export const renderPreviewComment = ({ branch, prototypes, runUrl }) => {
? [
"The preview deployment is ready. Paste a URL below into **Load Developer Extensions from URL** in Roam:",
"",
...previews.map(
({ prototype, url }) => `- [Load \`${prototype}\` in Roam](${url})`,
),
...previews.map(({ url }) => `- ${url}`),
].join("\n")
: "CI passed, but this branch does not contain an installable prototype yet.";
const details = runUrl ? `\n\n[View publishing details](${runUrl})` : "";
Expand Down
5 changes: 3 additions & 2 deletions test/comment-preview.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test("serializes publishing runs without interrupting an active upload", async (
assert.match(workflow, /cancel-in-progress: false/);
});

test("renders resolved Roam preview links", () => {
test("renders resolved Roam preview URLs without link labels", () => {
const body = renderPreviewComment({
branch: "agent/stock-prototype",
prototypes: ["stock-prototype"],
Expand All @@ -34,8 +34,9 @@ test("renders resolved Roam preview links", () => {
assert.match(body, new RegExp(PREVIEW_COMMENT_MARKER));
assert.match(
body,
/https:\/\/discoursegraphs\.com\/releases\/prototypes\/previews\/agent--stock-prototype\/stock-prototype\//,
/- https:\/\/discoursegraphs\.com\/releases\/prototypes\/previews\/agent--stock-prototype\/stock-prototype\//,
);
assert.doesNotMatch(body, /Load `stock-prototype` in Roam/);
assert.match(body, /Load Developer Extensions from URL/);
assert.match(body, /actions\/runs\/123/);
});
Expand Down