fix(prelaunch): survive set -u when app-compose sources script (v0.0.20) - #116
Merged
Conversation
Mirror the Phala Cloud official pre-launch bump. dstack app-compose.sh now
runs with set -euo pipefail and sources pre_launch_script, so bare
"$DSTACK_DOCKER_USERNAME" aborts boot when registry credentials are unset.
- Expand optional env via ${VAR-}/${VAR:-}
- Default DOCKER_REGISTRY_TARGET before credential branches
- Flatten pipelines so the script has no backslash line continuations
- Keep fingerprint / password helpers nounset-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-compose.shsourcespre_launch_scriptunderset -euo pipefail; v0.0.19 died withDSTACK_DOCKER_USERNAME: unbound variablewhen no registry credentials were set.Test plan
CURRENT_PRE_LAUNCH_SCRIPT(v0.0.20) for content parityset -euo pipefailwith noDSTACK_*env and confirm completion (see monorepo regression test)