fix(dstack-mr-cli): default --hotplug-off to the VMM's default - #1405
Merged
Merged
Conversation
#1387 made the VMM default qemu_hotplug_off to true and made ACPI generation reject hotplug with GPU root ports, but left the CLI defaulting to false. A measurement of a default VMM CVM therefore came out wrong, and one with GPUs failed with HotplugWithRootPorts, unless --hotplug-off true was passed. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
added a commit
that referenced
this pull request
Sep 25, 2026
The measure CLI defaulted --hotplug-off to false and now follows the VMM default of true (PR #1405), while diagnose reads hotplug_off from the VmConfig, where it defaults to false. The diagnose-matches-measure row therefore compared two machines that differ in the ACPI tables, and RTMR[0] diverged. Pass --hotplug-off on every measure row and hotplug_off in the diagnose VmConfig, so the matrix measures the same machine whichever default the CLI ships. The advanced-machine-fields row now turns hotplug on so it still moves the field away from the baseline. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1387 changed the VMM default to
qemu_hotplug_off = trueand made ACPI generation reject hotplug with GPU root ports, butdstack-mr measurestill defaulted--hotplug-offtofalse. Measuring a default-configured CVM therefore gave the wrong RTMRs, and--num-gpus 1failed withHotplugWithRootPortsunless the flag was passed explicitly.Found by the PR 841 acceptance suite (
tc-ver-tools-001/002GPU rows).Verification
dstack-mr measure --helpshows[default: true].cargo test -p dstack-mr-clipasses.