Restrict missing software check to after deploy label is set - #1505
Restrict missing software check to after deploy label is set#1505ocaisa wants to merge 14 commits into
Conversation
e01ba8e to
2cceb6e
Compare
|
To whomever reviews this, you can see that the the missing installation test is currently skipped. To force the check to run you add the label However, I would like to also make sure that we require the missing installations check before a PR is merge-able (which it seems like is not quite the status) |
|
Actually, it seems the the required checks are indeed held back, this PR should not be mergable even with a positive review |
|
I'm going to take this further, I plan to
|
ocaisa
added
force-ci-checks
ocaisa
added
force-ci-checks
ocaisa
added
force-ci-checks
ocaisa
added
force-ci-checks
| permissions: | ||
| contents: read # to fetch code (actions/checkout) | ||
| env: | ||
| # list below should correspond with table @ https://eessi.io/docs/software_layer/cpu_targets/ |
There was a problem hiding this comment.
This really should be a file in the repository that is read so that it can be easily reused by other CI
| types: | ||
| - opened | ||
| - synchronize | ||
| - labeled |
There was a problem hiding this comment.
Any reason not to add reopened here as well? Also, you might as well one-line this.
| types: | |
| - opened | |
| - synchronize | |
| - labeled | |
| types: [opened, synchronize, reopened, labeled] |
| # Use GITHUB_OUTPUT heredoc correctly | ||
| echo "EESSI_VERSIONS<<EOF" >> "$GITHUB_OUTPUT" | ||
| echo "$EESSI_VERSIONS" >> "$GITHUB_OUTPUT" | ||
| echo "2025.06" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
I'm confused, why is this version hard-coded now? Or was that part of a test and should that change be reverted?
2 participants
No description provided.