Skip to content

Revert "Perf playbook: measure, identify, fix, verify with a rerunnable ledger (#549)" - #567

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/revert/perf-playbook-549-20260913/revert-perf-playbook-measure-identify-fix-verify--08342e13
Sep 14, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/revert/perf-playbook-549-20260913/revert-perf-playbook-measure-identify-fix-verify--08342e13

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

This removes a speed-work playbook that reached the main branch before it was ready.

The problem: its worked examples were meant to copy real past episodes. Checked one by one, eleven of eighteen had made-up numbers.

The cause: the examples were written to fit the rules. Extra runs and results were invented, so a green check proved nothing.

The fix: undo that merge. The playbook will be rebuilt later, starting from a check against the real episodes.

Review Claim

The playbook, its script, and its worked examples are removed, returning the repository to how it was before that merge.

Review Lane

behavior

Review Unit

product-skill

Safety Invariant

Removes only the five files the merged pull request added, all inside one skill folder; nothing outside that folder refers to the skill, so no other skill, hook, or install step changes.

Slice Rationale

A plain revert of one merge, kept alone so it can land without waiting on the rebuild.

Non-goals

  • No rebuild of the playbook in this pull request.
  • No change to any other skill, hook, or the landing workers.

Test Plan

Test Plan

git revert 0a2eb69 removes 5 files (310 deletions). No file outside the skill folder names the skill on origin/main (git grep -n measure-then-optimize origin/main outside that folder printed nothing).

unit    product-skill: 5 file(s)
declare Review Unit: product-skill
gate    python3 scripts/check_codify_has_code.py --base origin/main
        ok      codify-has-code
gate    python3 scripts/check_no_dated_provenance.py --base origin/main
        ok      no dated provenance
gate    python3 scripts/check_skills_three_harnesses.py
        ok      skills three-harness check
gate    python3 scripts/check_ecosystem_boundaries.py
        ok      ecosystem boundaries
gate    python3 scripts/check_skill_file_refs.py
        ok      skill file refs
gate    python3 scripts/check_skill_test_coverage.py --base origin/main --head HEAD
        ok      skill test coverage
gate    python3 scripts/check_skill_trigger_mechanism.py
        ok      skill trigger mechanism
gate    python3 scripts/check_skill_trigger_policy.py
        ok	skill trigger policy
gate    python3 scripts/check_subagent_scope_contract.py
        ok	subagent scope contract
gate    python3 scripts/run_skill_scenarios.py
        ok  	subagent-fact-attributed
        ok  	stale-green-caught-without-any-admission
        ok  	stale-green-already-owned-by-the-reply
        ok  	red-then-green-is-a-fix-not-a-stale-claim
        
        ok	all 17 scenario(s) behaved as declared
gate    description_check /private/tmp/claude-501/-Users-edbertchan-Documents-GitHub-catstack/9b25a21a-0b29-4a9a-bcff-548fc74d2eef/scratchpad/pr-revert-549.md
        description clean
ok      preflight passed

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <merge sha of this PR> (restores the five files)
  • Post-revert steps: None
  • Data migration? No

🤖 Generated with Claude Code

@cursor

cursor Bot commented Sep 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_d71ec423-8a37-46cb-b08e-be7927118625)

@mergify

mergify Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

…le ledger (#549)"

This reverts commit 0a2eb69.

A backtest found 11 of the skill's 18 case ledgers misstate their source
episode: extra runs and after-values were invented to fit the verdict
rules, so its passing tests do not reflect the real episodes. The PR was
closed for a restart with the backtest as the first step, but it had
already been merged through the admin-bypass landing queue.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I08342e132a07da4b010def75bf3f54cc4d9a5a9e
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/revert/perf-playbook-549-20260913/revert-perf-playbook-measure-identify-fix-verify--08342e13 branch from 99f138c to e5cbc53 Compare September 14, 2026 04:12
@cursor

cursor Bot commented Sep 14, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_1e9c9725-b2de-4fb5-9c8d-aaba17aea02f)

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 6 minutes 46 seconds in the queue, including 4 minutes 53 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test
  • check-success = validate

@mergify mergify Bot added the queued label Sep 14, 2026
@mergify
mergify Bot merged commit 44a545d into main Sep 14, 2026
7 checks passed
@mergify
mergify Bot deleted the stack/EdbertChan/revert/perf-playbook-549-20260913/revert-perf-playbook-measure-identify-fix-verify--08342e13 branch September 14, 2026 04:25
@mergify mergify Bot removed the queued label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant