-
Notifications
You must be signed in to change notification settings - Fork 291
Track marketing notification opens #6067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peachbits
wants to merge
2
commits into
develop
Choose a base branch
from
matthew/marketing-push-tracking
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { describe, expect, it } from '@jest/globals' | ||
| import type { FirebaseMessagingTypes } from '@react-native-firebase/messaging' | ||
|
|
||
| import { parsePushMessage } from '../util/PushMessageParser' | ||
|
|
||
| // The parser only uses `showDevError` from AirshipInstance; stub it so the test | ||
| // avoids pulling in the native Airship module. | ||
| jest.mock('../components/services/AirshipInstance', () => ({ | ||
| showDevError: () => undefined | ||
| })) | ||
|
|
||
| /** | ||
| * Builds a minimal RemoteMessage; the parser only reads `data` and | ||
| * `notification`. | ||
| */ | ||
| function makeMessage( | ||
| data: Record<string, string> | undefined, | ||
| notification?: { title?: string; body?: string } | ||
| ): FirebaseMessagingTypes.RemoteMessage { | ||
| return { | ||
| data, | ||
| notification | ||
| } as unknown as FirebaseMessagingTypes.RemoteMessage | ||
| } | ||
|
|
||
| describe('parsePushMessage', () => { | ||
| it('captures the campaignId from a marketing payload', () => { | ||
| expect( | ||
| parsePushMessage(makeMessage({ type: 'marketing', campaignId: 'abc123' })) | ||
| ).toEqual({ | ||
| type: 'marketing', | ||
| campaignId: 'abc123', | ||
| link: undefined | ||
| }) | ||
| }) | ||
|
|
||
| it('parses an optional deep-link url into a nested navigation link', () => { | ||
| expect( | ||
| parsePushMessage( | ||
| makeMessage({ | ||
| type: 'marketing', | ||
| campaignId: 'abc123', | ||
| url: 'edge://swap' | ||
| }) | ||
| ) | ||
| ).toEqual({ | ||
| type: 'marketing', | ||
| campaignId: 'abc123', | ||
| link: { type: 'swap' } | ||
| }) | ||
| }) | ||
|
|
||
| it('degrades to track-only when the url is unparseable', () => { | ||
| expect( | ||
| parsePushMessage( | ||
| makeMessage({ | ||
| type: 'marketing', | ||
| campaignId: 'abc123', | ||
| url: 'not a url' | ||
| }) | ||
| ) | ||
| ).toEqual({ | ||
| type: 'marketing', | ||
| campaignId: 'abc123', | ||
| link: undefined | ||
| }) | ||
| }) | ||
|
|
||
| it('ignores a non-marketing payload', () => { | ||
| expect(parsePushMessage(makeMessage({ foo: 'bar' }))).toBeUndefined() | ||
| }) | ||
|
|
||
| it('still parses a price-change payload', () => { | ||
| expect( | ||
| parsePushMessage( | ||
| makeMessage( | ||
| { type: 'price-change', pluginId: 'bitcoin' }, | ||
| { body: 'BTC is up' } | ||
| ) | ||
| ) | ||
| ).toEqual({ | ||
| type: 'price-change', | ||
| pluginId: 'bitcoin', | ||
| body: 'BTC is up' | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Agentic Security Review
Severity: MEDIUM
The marketing push path accepts any recognized deep link type from
message.data.urland forwards it into the shared deep-link dispatcher. This means a marketing payload is not constrained to benign campaign destinations and can invoke broader in-app actions.Impact: A compromised or misconfigured campaign sender could cause notification opens to trigger higher-risk flows (for example auth/session or internal navigation handlers) instead of only safe marketing navigation.
Reviewed by Cursor Security Reviewer for commit b4eafc8. Configure here.