test: add createWalletRow testID for maestro selectors#6073
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae897e3. Configure here.
ae897e3 to
8a823ef
Compare
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.

CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
Test infrastructure only. No runtime behavior change: this adds a
testIDpropand nothing else.
Asana: https://app.asana.com/1/9976422036640/project/1215088146871429/task/1216603961673510
While driving the NYM mix-fetch v2 investigation on the sim (edge-core-js#731),
the create-wallet rows had no stable selector, so a maestro flow could not pick a
chain to create. Text matching does not hit the row's touchable.
Adds
testID={createWalletRow.${pluginId}}toCreateWalletSelectCryptoRow,which lets a flow drive a specific chain deterministically:
Verified by using it: this selector is what unblocked creating an Avalanche
wallet for that run.
Related harness gap (not fixed here)
The
Nextbutton oncreateWalletSelectCryptois absent from the accessibilityhierarchy, so no selector reaches it — maestro reports both
Next is visible... FAILEDandid: nextButton not foundwhile the button is plainly on screen. ItstestID already exists (
CreateWalletSelectCryptoScene.tsx) and is forwarded byButtonsView; the cause isSceneButtonsrendered withabsolute={!isMaestro()}inside an
EdgeAnimwithaccessible={false}.The repo's own accommodation,
ENABLE_MAESTRO_BUILD, makes it hierarchy-visiblebut also repoints the login backend — enabling it logged the test account out
with
Account does not exist on server. So the maestro accommodation and a realaccount login are currently mutually exclusive, and driving that button needs a
coordinate tap. Worth fixing separately.
Requirements
No visual changes to the GUI — this PR adds a
testIDprop and nothing else, sothe device-matrix checks below do not apply.
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Test-only
testIDwiring with no production logic changes.Overview
Adds stable Maestro / E2E selectors on create-wallet list rows so flows can tap a specific chain or token without relying on text that does not hit the row touchable.
CreateWalletSelectCryptoRowgains an optionaltestID(documented to use each list item’s uniquekey, notpluginId, because one plugin can render multiple rows).CreateWalletSelectCryptoScenesetstestID={createWalletRow.${key}}on each row and forwards it to the row’sEdgeTouchableOpacity. Jest snapshots are updated accordingly.No user-visible or functional wallet-creation behavior changes.
Reviewed by Cursor Bugbot for commit 8a823ef. Bugbot is set up for automated code reviews on this repo. Configure here.