Skip to content

test: add createWalletRow testID for maestro selectors#6073

Open
j0ntz wants to merge 1 commit into
developfrom
jon/nym-mixfetch-v2-chain-wedge
Open

test: add createWalletRow testID for maestro selectors#6073
j0ntz wants to merge 1 commit into
developfrom
jon/nym-mixfetch-v2-chain-wedge

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

Asana task

Test infrastructure only. No runtime behavior change: this adds a testID prop
and nothing else.

Asana: https://app.asana.com/1/9976422036640/project/1215088146871429/task/1216603961673510

While driving the NYM mix-fetch v2 investigation on the sim (edge-core-js#731),
the create-wallet rows had no stable selector, so a maestro flow could not pick a
chain to create. Text matching does not hit the row's touchable.

Adds testID={createWalletRow.${pluginId}} to CreateWalletSelectCryptoRow,
which lets a flow drive a specific chain deterministically:

- tapOn:
    id: "createWalletRow.avalanche"

Verified by using it: this selector is what unblocked creating an Avalanche
wallet for that run.

Related harness gap (not fixed here)

The Next button on createWalletSelectCrypto is absent from the accessibility
hierarchy, so no selector reaches it — maestro reports both Next is visible... FAILED and id: nextButton not found while the button is plainly on screen. Its
testID already exists (CreateWalletSelectCryptoScene.tsx) and is forwarded by
ButtonsView; the cause is SceneButtons rendered with absolute={!isMaestro()}
inside an EdgeAnim with accessible={false}.

The repo's own accommodation, ENABLE_MAESTRO_BUILD, makes it hierarchy-visible
but also repoints the login backend — enabling it logged the test account out
with Account does not exist on server. So the maestro accommodation and a real
account login are currently mutually exclusive, and driving that button needs a
coordinate tap. Worth fixing separately.

Requirements

No visual changes to the GUI — this PR adds a testID prop and nothing else, so
the device-matrix checks below do not apply.

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Test-only testID wiring with no production logic changes.

Overview
Adds stable Maestro / E2E selectors on create-wallet list rows so flows can tap a specific chain or token without relying on text that does not hit the row touchable.

CreateWalletSelectCryptoRow gains an optional testID (documented to use each list item’s unique key, not pluginId, because one plugin can render multiple rows). CreateWalletSelectCryptoScene sets testID={createWalletRow.${key}} on each row and forwards it to the row’s EdgeTouchableOpacity. Jest snapshots are updated accordingly.

No user-visible or functional wallet-creation behavior changes.

Reviewed by Cursor Bugbot for commit 8a823ef. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ae897e3. Configure here.

Comment thread src/components/themed/CreateWalletSelectCryptoRow.tsx Outdated
@j0ntz j0ntz force-pushed the jon/nym-mixfetch-v2-chain-wedge branch from ae897e3 to 8a823ef Compare July 15, 2026 20:33

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant