Zcash: Orchard → Ironwood (NU6.3) migration UX#6077
Draft
peachbits wants to merge 4 commits into
Draft
Conversation
Typed access to the accountbased engine's Orchard->Ironwood migration surface (wallet.otherMethods is untyped): mirrored cleaners, getZcashMigrationStatus (undefined for non-zcash wallets, engines without the methods, or gated platforms - Android is gated until its SDK ships Ironwood), prepare/confirm plan wrappers that round-trip the engine's opaque plan tokens, and a useRefresher-based polling hook that is safe to call unconditionally from shared scenes. Strings for the whole feature. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Four scenes mirroring the ZODL reference UX: options (privacy default vs immediate with an amount-visibility warning; redirects to progress when a migration is already in motion), how-it-works explainer for the privacy path, plan confirmation (transfer list with executable-time estimates, totals, preparation fee, duration, cannot-cancel warning for immediate; confirms via the engine which pre-signs exactly the reviewed plan), and live N-of-M progress with stale-transfer retry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Three condition-gated surfaces, all dormant until the engine reports the wallet needs (or is running/erred on) the migration - no fork-date gating needed: a warning card on the wallet scene under the sync status card, a per-wallet notification-center card (ironwoodMigration-<walletId>, armed by a new ZcashMigrationService poller; the condition mechanism automatically re-surfaces it if new Orchard funds arrive after completion), and a kebab menu item gated to the zcash plugin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
react-native-zcash and edge-currency-accountbased are pinned to the prebuilt Ironwood tarballs hosted on the react-native-zcash ironwood-ffi-a9637998 release (from EdgeApp/react-native-zcash#71 and EdgeApp/edge-currency-accountbased#1075) until upstream Ironwood SDK releases exist; swapped to npm versions at release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zcash: Orchard → Ironwood (NU6.3) migration UX
Zcash's Ironwood hardfork (~end of July) introduces a new shielded pool; users must migrate Orchard funds. This is the GUI layer over EdgeApp/edge-currency-accountbased#1075 (engine) and EdgeApp/react-native-zcash#71 (SDK bridge). Both migration paths ship, mirroring the ZODL reference UX: Migrate with Privacy (default: note split → randomized scheduled transfers, pre-signed once, executed as the user opens the app) and Migrate Immediately (single transfer with an amount-visibility warning).
Commits
ffee06824— otherMethods wrappers + status hook.util/zcashMigration.ts(mirrored cleaners;getZcashMigrationStatusreturns undefined for non-zcash wallets, old engines, or gated platforms —ZCASH_MIGRATION_PLATFORMS = ['ios']until the Android SDK ships) +useZcashMigrationStatuspolling hook (safe to call unconditionally). All strings.f7d6e8181— four scenes. Options (privacy default vs immediate + warning; redirects to progress when already in motion) → How-it-works → Plan confirm (transfer list with executable-time estimates, totals, prep fee, duration; cannot-cancel warning for immediate; the engine pre-signs exactly the reviewed plan via opaque token round-trip) → live N-of-M progress with stale-transfer Retry.47d7a2b76— entry points. All condition-gated on engine-reported status (dormant pre-activation, no fork-date gate needed): wallet-scene warning card under the sync card; per-wallet notification-center card (ironwoodMigration-<walletId>, armed by a newZcashMigrationServicepoller — the condition mechanism auto-re-surfaces it if new Orchard funds arrive after completion); kebab menu item gated tozcash.587aded21— pins + changelog. react-native-zcash + edge-currency-accountbased pinned to the prebuilt Ironwood tarballs (hosted on theironwood-ffi-a9637998release); swapped to npm versions at SDK release.Persistence model
The SDK database is the sole source of truth (schedule + pre-signed transactions persist there; one-off-per-wallet falls out). GUI stores only notification dismissal state in local
notifState. Nothing in synced settings — a synced "done" bit could go stale when new Orchard funds arrive.Validation
tscclean, eslint 0 errors on changed files, jest 6/6 (zcashMigration.test.ts, fake-wallet matrix incl. method-missing and malformed-shape fallbacks).Notes for review
navigation.navigate('zcashMigrationOptions' as any, …)casts in WalletsTab-scoped contexts (TransactionListTop, WalletListMenuActions, notification views) — the migrate scenes live on the App stack; this mirrors how cross-stack navigation is handled elsewhere but flagging for preferred style.FiatTextif wanted.proposeImmediateMigration), not a workaround.🤖 Generated with Claude Code