Added action for validating the clab topology - #4
Merged
Conversation
Owner
Author
|
Can confirm it works too |
Collaborator
|
Looks good but I don't have any clab experience to be confident in reviewing |
Owner
Author
The command in the action parses the topology and generates a graph to visualise the network, in order for it to do this it'll need to validate the topology to verify it'll work as both a graph and network when deployed. I broke the topology to do an in-pr run of the action which produced this error showing it worked. https://github.com/ErcModel3/Aquila/actions/runs/23514109252/job/68442222595#step:4:1 I have the most clab experience here just blind approve it as it works 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says on the Tin, the implementation may need to change as we scale up (to using self-hosted runners in the lab) as it can be resource heavy, just adds an action that downloads containerlab and runs a graphing command (used as a validation check)