Skip to content

fix: shorten localized labels - #567

Merged
lowrt merged 3 commits into
mainfrom
ci
Sep 12, 2026
Merged

lowrt merged 3 commits into
mainfrom
ci

Conversation

@lowrt

@lowrt lowrt commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

這個 PR 做了什麼

縮短部分地圖圖層的英語名稱
避免部分語言文字過長,超出 UI 容器

相關 issue

  • closes #

怎麼驗

檢查清單

  • tool/check/commits.sh origin/main..HEAD 通過
    —— commit 訊息就是更新日誌,格式見 commit.md
  • 一個 commit 一件事(這條 gate 驗不了,靠自己和 review)
  • mise exec -- flutter analyzemise exec -- flutter test 通過
  • 新的使用者可見字串都走 AppLocalizations,沒有寫死
  • 有 UI 變更的話:用的是 AppSpacing / AppRadius / AppMotion
    深色模式看過,文字對比度可接受

@lowrt
lowrt requested a review from a team as a code owner September 6, 2026 14:23
@lowrt
lowrt enabled auto-merge (rebase) September 6, 2026 14:23
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

🔍 OpenCodeReview found 7 issue(s) in this PR.

  • ✅ Successfully posted inline: 7 comment(s)

Comment thread .github/workflows/android.yml
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Sep 7, 2026
@lowrt lowrt changed the title ci: update Android and iOS actions fix: shorten localized labels Sep 7, 2026
@lowrt
lowrt disabled auto-merge September 7, 2026 06:19
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment thread .github/workflows/android.yml
Comment thread .github/workflows/android.yml
Comment thread .github/workflows/ios.yml
Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
@lowrt
lowrt force-pushed the ci branch 2 times, most recently from 5bf587a to 817f539 Compare September 7, 2026 07:31
@lowrt
lowrt enabled auto-merge (rebase) September 7, 2026 08:05
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment thread lib/l10n/gen/app_localizations_fil.dart
Comment thread lib/l10n/gen/app_localizations_id.dart
Comment thread lib/l10n/gen/app_localizations_th.dart
Comment thread lib/l10n/gen/app_localizations_vi.dart
Comment thread lib/l10n/gen/app_localizations.dart
- Upgrade checkout and cache actions to current versions
- Remove redundant Gradle cache from Android CI
- Keep release workflow cache cleanup for a separate change
Fix(zh-Hant): 縮短多語系名稱以避免文字超出容器
Fix(en-US): shorten localized labels to prevent text overflow
@lowrt lowrt added this to the v26.3 milestone Sep 10, 2026
@lowrt
lowrt merged commit 00db004 into main Sep 12, 2026
6 checks passed
@lowrt
lowrt deleted the ci branch September 12, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants