Skip to content

fix(test): spawn the emulator test harness via an absolute /bin/sh #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
Aug 23, 2026
Merged

fix(test): spawn the emulator test harness via an absolute /bin/sh #1389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/fbuild-daemon/src/handlers/emulator/tests_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,16 @@ pub(super) fn test_process_command(lines: &[&str]) -> (PathBuf, Vec<String>) {
.map(|line| format!("printf '%s\\n' '{}'", line.replace('\'', "'\"'\"'")))
.collect::<Vec<_>>()
.join("; ");
(PathBuf::from("sh"), vec!["-c".to_string(), script])
// Absolute, not a bare `sh` resolved through PATH. The Windows branch
// above already builds an absolute `cmd.exe` path; this side did not,
// and an ubuntu runner failed with
//
// failed to launch QEMU at sh: No such file or directory (os error 2)
//
// which is a PATH lookup miss dressed up as a missing emulator. POSIX
// requires `/bin/sh`, so naming it outright removes the runner's
// environment from the equation entirely.
(PathBuf::from("/bin/sh"), vec!["-c".to_string(), script])
}
}

Expand Down
Loading