fix: name generated engine classes from schema titles - #227
Merged
Merged
Conversation
emyller
previously approved these changes
Sep 23, 2026
Zaimwa9
force-pushed
the
fix/pin-schema-refs
branch
from
September 23, 2026 14:55
5603f00 to
6beeffe
Compare
Zaimwa9
changed the title
Zaimwa9
force-pushed
the
fix/pin-schema-refs
branch
from
September 23, 2026 14:59
6beeffe to
6ae2da2
Compare
emyller
previously approved these changes
Sep 23, 2026
emyller
left a comment
emyller
left a comment
Contributor
There was a problem hiding this comment.
Approving because my one comment is not blocking, but I'd love to see it followed up.
Upstream 58eb348 added a `flags` property to the evaluation context. jsonschema2pojo names classes from the property name, so it collided with the evaluation result's `flags`: one became Flags__1 and Engine.java no longer compiled. CI had failed on every branch since 2026-08-31. Name classes from the schema title instead. Every object in the upstream schemas has a unique title matching its current generated name, so the generated set is unchanged apart from the new FlagResults (titled so by upstream Flagsmith/flagsmith#8581). The schema refs keep tracking main.
Zaimwa9
force-pushed
the
fix/pin-schema-refs
branch
from
September 23, 2026 15:11
6ae2da2 to
5b8ec36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
CI has failed on every branch since 2026-08-31. Upstream Flagsmith/flagsmith#8396 added a
flagsproperty to the evaluation context; jsonschema2pojo names classes from the property name, so it collided with the evaluation result'sflags, emittingFlags__1and breakingEngine.java:45.Switches the plugin to
useTitleAsClassname. Every object in the upstream schemas has a unique title matching its current generated name, so the generated class set is unchanged apart from the newFlagResults(titled by Flagsmith/flagsmith#8581). Schema$refs keep trackingmain.How did you test this code?
mvn clean installandmvn clean install -P test-okhttp4against upstreammain: 406 passed each, 0 checkstyle violations. Generated classes identical to before plusFlagResults.