ci: added macOS build job - #134
Merged
Merged
Conversation
|
Current version of PR was reviewed by /review-bugbot on Jul 27, 14:26 PDT. It flagged 0 findings. Bugbot on commit |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
macOS support had no enforcement, so any change could silently break it. A macos-15 (arm64) job builds its own Darwin-scoped sysroot caches and runs the full make test flow for both architectures on every push. Co-authored-by: Cursor <cursoragent@cursor.com>
FlareCoding
force-pushed
the
pr/macos-ci-job
branch
from
July 29, 2026 17:18
2894467 to
341984d
Compare
checksharedmods runs the build interpreter with PYTHONPATH into the cross-build tree, so its own imports can dlopen cross-built Linux ELF modules and crash on macOS build pythons with dynamic stdlib modules. The guard exits before any shadowable import; Linux hosts run the check unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
FlareCoding
force-pushed
the
pr/macos-ci-job
branch
from
July 29, 2026 18:06
341984d to
4eac2a9
Compare
FlareCoding
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-15(arm64) job builds the sysroots (Darwin-scoped caches), kernel, userland, and disk image for both architectures on every push; unit-test execution stays on the Linux jobs.Note
Low Risk
Changes are limited to CI workflow and a macOS-only skip in Python’s extension-module lint; runtime kernel behavior is unchanged.
Overview
Adds macOS CI coverage so cross-host builds are enforced on every push/PR, without moving QEMU unit tests off Linux.
A new
macos-buildjob runs onmacos-15in parallel with the existing Ubuntubuildmatrix (both still gate ondynpriv-lint). It cross-builds x86_64 and aarch64, reusing Darwin-specific cache keys for musl/libc++/compiler-rt, then runsmake imageand assertskernel.elfplusimages/stellux-<arch>.imgexist.unit-testsremainsneeds: buildonly.A small Python patch exits early from
check_extension_modules.pyon non-Linux hosts so macOS cross-builds do not run a host-side shared-module check that candlopenLinux ELF modules and crash.Reviewed by Cursor Bugbot for commit 4eac2a9. Bugbot is set up for automated code reviews on this repo. Configure here.