Skip to content

feat(stlxterm): VT100/xterm escape expansion - #145

Merged
FlareCoding merged 1 commit into
masterfrom
pr/stlxterm-vt100
Jul 30, 2026
Merged

feat(stlxterm): VT100/xterm escape expansion#145
FlareCoding merged 1 commit into
masterfrom
pr/stlxterm-vt100

Conversation

@FlareCoding

Copy link
Copy Markdown
Owner

Summary

Supersedes #142, which became unmergeable after GitHub flagged it as a stack.

Made with Cursor

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

Current version of PR was reviewed by /review-bugbot on Jul 30, 13:23 PDT. It flagged 2 findings.

Show 2 findings

1. DECSTBM homes wrong cursor row

userland/apps/stlxterm/src/term.c:400 · Medium Severity

After handling DECSTBM (CSI r), the cursor is always placed at screen row 0 instead of the top line of the newly configured scroll region (scroll_top). Programs that set a non-zero top margin (e.g. \e[2;24r) expect the cursor at that margin line; placing it at row 0 breaks origin/region-relative drawing and scrolling.

2. Alt screen keeps scroll margins

userland/apps/stlxterm/src/term.c:157 · Medium Severity

Switching to or from the alternate screen (DECSET 1047/1049) saves and restores cell buffers and cursor position but never resets or restores scroll_top/scroll_bottom. xterm-compatible full-screen apps expect full-window margins on the alt buffer and the previous margins restored on exit.

Bugbot on commit 3fe29bb is skipped.

@FlareCoding
FlareCoding merged commit ec9ba71 into master Jul 30, 2026
15 checks passed
@FlareCoding
FlareCoding deleted the pr/stlxterm-vt100 branch July 30, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant