Обновлены статьи по последним изменениям ORM .net10#233
Conversation
WalkthroughОбновлена документация Flexberry ORM на русском и английском языках: добавлены сведения о CI/CD, миграции API и DI, интерфейсе ChangesДокументация Flexberry ORM
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 17
🧹 Nitpick comments (1)
pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md (1)
40-46: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winДобавить предупреждение о legacy-характере BinaryFormatter в обеих локализациях.
pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md#L40-L46: явно предупредить о запрете использования для недоверенных данных.pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.ru.md#L38-L44: добавить эквивалентное русское предупреждение.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md` around lines 40 - 46, Добавьте в pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md в разделе с зависимостью System.Runtime.Serialization.Formatters явное предупреждение о legacy-характере BinaryFormatter и запрете его использования для недоверенных данных. В pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.ru.md добавьте эквивалентное предупреждение на русском; остальные сведения о зависимостях и поддержке .NET Core не изменяйте.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md`:
- Line 104: Добавьте завершающий символ новой строки в
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
на строке 104 и
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
на строке 104, не изменяя содержимое файлов.
- Around line 77-83: Correct the Docker example so the PostgreSQL and MSSQL
sections use valid YAML or shell-command syntax, preserving the intended
health-retry option and MSSQL image configuration. Apply the same synchronized
correction in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
at lines 77-83 and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
at lines 77-83.
- Around line 88-91: Replace the unauthenticated ssh-keyscan setup in the SSH
initialization block with a trusted GitHub host-key source, using GitHub’s
published fingerprints or the known_hosts data from api.github.com/meta. Apply
the same change in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md:88-91
and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md:88-91,
preserving the subsequent ssh-agent and ssh-add steps.
- Around line 17-22: Synchronize the documented GitHub Actions versions in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
lines 17-22 and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
lines 17-22: update actions/checkout to v7 and actions/setup-dotnet to v5, or
remove the “latest” wording in both files.
In `@pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md`:
- Line 54: Add exactly one trailing newline to each listed Markdown file:
pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md (line 54),
pages/products/flexberry-orm/api/fo_flexberry-orm-api.ru.md (line 52),
pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md
(line 212),
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md (line
119), and pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md
(line 119).
In
`@pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md`:
- Around line 129-131: Mark the preceding Unity-based instructions as applicable
to legacy Flexberry ORM versions, creating a clear boundary before the new DI
approach. Apply the equivalent legacy annotation in
pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md:129-131
and
pages/products/flexberry-orm/current-user-service/fo_current-user-service.ru.md:127-129,
and mark the Unity algorithm similarly in
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md:84-86 and
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md:84-86.
- Around line 186-192: Fix MD031 by inserting a blank line before every fenced
code block inside the listed examples:
pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md
lines 186-192 and fo_current-user-service.ru.md lines 184-190,
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md and
fo_ds-provider.ru.md lines 91-100, and
pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md lines
50-62 and fo_unity-factory.ru.md lines 48-60. Preserve the existing
Before/After, Было/Стало, and C# example content.
- Line 45: Correct the interface reference in the current-user service example
to ICSSoft.Services.CurrentUserService.IUser, and update the method reference to
ICSSoft.Services.CurrentUserService.ResolveUser<T>().
In `@pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md`:
- Around line 63-71: Replace the SQL mapping for funcSSPart in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md lines
63-71 and
pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md lines
61-69, changing SECOND to the correct PostgreSQL seconds expression while
keeping both localized tables consistent.
- Around line 73-79: Clarify the CRP generation warning in both documentation
versions: in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md lines
73-79, remove the ambiguous “before .NET 6+” wording; in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md lines
71-77, specify the exact Designer support boundary. Keep the warning’s
DateOnly/DATE correction guidance unchanged.
- Around line 2-5: Correct the English front matter and affected page text in
the PostgresDataService documentation: replace machine-translated phrases such
as “data Service” and “features of c PostgreSQL” with clear descriptions of
PostgresDataService and the citext extension, and correct the “registronacional”
wording while preserving the intended technical meaning.
- Around line 50-61: Update the constructor documentation in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md lines
50-61 so INotifyUpdateObjects is described as optional because it has a default
value; apply the same clarification to
pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md lines
48-59, while keeping the other required parameters unchanged.
- Around line 24-30: Synchronize the Npgsql version matrices in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md lines
24-30 and
pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md lines
22-28. Replace the “Current version” and “Latest version” labels with
descriptions of the actually supported versions, apply the same matrix in both
locales, and explicitly indicate that Npgsql 10 does not support .NET 6.
In `@pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md`:
- Around line 13-24: Revise the type list in the Flexberry ORM documentation to
use clear, grammatically correct English throughout: replace the Russian words
in the optional-types description, correct the “Optional types Flexberry ORM”
construction, and consistently write “User-defined types” with a hyphen.
Preserve the existing type entries and links while ensuring the section reads as
complete English documentation.
In `@pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md`:
- Around line 99-107: The DI documentation currently describes static
DetailVariableDef.ViewGenerator assignment as dependency injection. Update the
wording and examples to describe the transition to
DetailVariableDef.ViewGenerator, or explicitly identify it as a separate API
rather than an injected dependency. Apply the same correction in
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md lines
99-107, pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md
lines 99-107,
pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md lines
49-57, and
pages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md lines
47-55.
In `@pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md`:
- Line 15: Измените заголовок «Алгоритм инициализации
DataServiceProvider.DataService» с уровня ### на ##, чтобы он соответствовал
уровню первого заголовка документа и правилу MD001.
In `@pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md`:
- Around line 256-258: Correct the LINQ/LCS link direction so the “LINQ to LCS
conversion” heading in
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md
lines 256-258 links to the matching LINQ-to-LCS page, and apply the same aligned
heading and target correction in
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.ru.md
lines 253-256.
---
Nitpick comments:
In `@pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md`:
- Around line 40-46: Добавьте в
pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md в разделе с
зависимостью System.Runtime.Serialization.Formatters явное предупреждение о
legacy-характере BinaryFormatter и запрете его использования для недоверенных
данных. В pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.ru.md
добавьте эквивалентное предупреждение на русском; остальные сведения о
зависимостях и поддержке .NET Core не изменяйте.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4f628ac4-f1e5-4691-a58a-95d7494fe5ee
📒 Files selected for processing (16)
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.mdpages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.mdpages/products/flexberry-orm/api/fo_flexberry-orm-api.en.mdpages/products/flexberry-orm/api/fo_flexberry-orm-api.ru.mdpages/products/flexberry-orm/current-user-service/fo_current-user-service.en.mdpages/products/flexberry-orm/current-user-service/fo_current-user-service.ru.mdpages/products/flexberry-orm/data-service/fo_postgres-data-service.en.mdpages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.mdpages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.mdpages/products/flexberry-orm/data-types/fo_flexberry-orm-types.ru.mdpages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.mdpages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.mdpages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.mdpages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.mdpages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.mdpages/products/flexberry-orm/query-language/fo_linq-provider-faetures.ru.md
| The workflow uses the latest versions of GitHub Actions: | ||
|
|
||
| | Action | Old Version | New Version | | ||
| |--------|-------------|-------------| | ||
| | `actions/checkout` | v2 | v4 | | ||
| | `actions/setup-dotnet` | v1 | v4 | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the referenced docs and any explicit version references
git ls-files 'pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.*.md'
printf '\n--- EN excerpt ---\n'
sed -n '1,140p' pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md | nl -ba | sed -n '1,140p'
printf '\n--- RU excerpt ---\n'
sed -n '1,140p' pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md | nl -ba | sed -n '1,140p'
printf '\n--- search for version claims ---\n'
rg -n 'actions/(checkout|setup-dotnet)|latest versions|v[0-9]+' pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.*.mdRepository: Flexberry/flexberry.github.io
Length of output: 385
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Check whether the repo already documents exact action versions elsewhere
rg -n 'actions/checkout@v|actions/setup-dotnet@v|latest versions of GitHub Actions|latest versions' pages products .github -g '!**/node_modules/**'Repository: Flexberry/flexberry.github.io
Length of output: 2071
🌐 Web query:
actions/checkout latest major release actions/setup-dotnet latest major release GitHub releases
💡 Result:
As of July 15, 2026, the latest major releases for the specified GitHub Actions are as follows: - actions/checkout: v7 [1][2][3] - actions/setup-dotnet: v5 [4][5][6] Best Practices for Using Major Versions: GitHub Actions should be referenced by their major version tag (e.g., @v7) in workflow YAML files [7]. This practice ensures your workflows automatically receive non-breaking patch and minor updates while remaining protected from unexpected breaking changes introduced in new major versions [8][7]. How to Verify: You can always confirm the latest major version by visiting the "Releases" page of the respective repository on GitHub [9][5]. The repository maintainers typically update the major version tag (e.g., v7) to point to the most recent stable release within that series [8][7]. Usage Example: - uses: actions/checkout@v7 - uses: actions/setup-dotnet@v5 with: dotnet-version: 8.0.x [6] Avoid using the branch name (e.g., @main) for production workflows, as it contains the latest, potentially unstable code [7]. Always pin to a specific major version tag as shown above [3].
Citations:
- 1: https://github.com/actions/checkout/releases/tag/v7.0.0
- 2: https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/
- 3: https://tech-insider.org/ie/github-actions-tutorial-2026/
- 4: https://github.com/actions/setup-dotnet/releases/tag/v5.4.0
- 5: https://github.com/actions/setup-dotnet/releases
- 6: https://github.com/actions/setup-dotnet/blob/main/README.md
- 7: https://docs.github.com/en/enterprise-cloud@latest/actions/how-tos/create-and-publish-actions/manage-custom-actions
- 8: https://docs.github.com/actions/creating-actions/releasing-and-maintaining-actions
- 9: https://github.com/actions/checkout/releases
🌐 Web query:
site:github.com/actions/checkout/releases v5 actions/checkout
💡 Result:
The actions/checkout action has released several versions since v5.0.0, which was published on August 11, 2025 [1]. Key highlights for the v5 release included an update to Node.js 24 [1] and a requirement for a minimum runner version of v2.327.1 [1][2]. Since that time, the action has continued to evolve: - v5.0.1 was released on November 17, 2025, incorporating cleanup changes [3]. - v6.0.0 was released on November 20, 2025, which included changes such as persisting credentials to a separate file [4]. - Several v6.x updates followed, including v6.0.2 in January 2026 [5] and v6.0.3 in June 2026, which added support for SHA-256 repositories [6]. - As of July 15, 2026, the latest major version is v7.0.0, which was released on June 18, 2026 [7]. Users are encouraged to check the official GitHub actions/checkout releases page for the most current version and specific migration notes [2].
Citations:
- 1: https://github.com/actions/checkout/releases/tag/v5.0.0
- 2: https://github.com/actions/checkout/releases
- 3: https://github.com/actions/checkout/releases/tag/v5.0.1
- 4: https://github.com/actions/checkout/releases/tag/v6.0.0
- 5: https://github.com/actions/checkout/releases/tag/v6.0.2
- 6: https://github.com/actions/checkout/releases/tag/v6.0.3
- 7: https://github.com/actions/checkout/releases/tag/v7.0.0
Синхронно обновите версии Actions в обоих файлах. Сейчас actions/checkout и actions/setup-dotnet уже не соответствуют “latest”; замените на actions/checkout@v7 и actions/setup-dotnet@v5, либо уберите это слово.
📍 Affects 2 files
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L17-L22(this comment)pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L17-L22
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md`
around lines 17 - 22, Synchronize the documented GitHub Actions versions in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
lines 17-22 and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
lines 17-22: update actions/checkout to v7 and actions/setup-dotnet to v5, or
remove the “latest” wording in both files.
Source: MCP tools
| ```yaml | ||
| # PostgreSQL | ||
| --health-retries 10 | ||
|
|
||
| # MSSQL | ||
| image: mcr.microsoft.com/mssql/server:2022-CU10-ubuntu-20.04 | ||
| ``` |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Синхронно исправьте Docker-пример.
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L77-L83: приведите валидный YAML или shell-команду.pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L77-L83: повторите исправление в русской версии.
📍 Affects 2 files
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L77-L83(this comment)pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L77-L83
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md`
around lines 77 - 83, Correct the Docker example so the PostgreSQL and MSSQL
sections use valid YAML or shell-command syntax, preserving the intended
health-retry option and MSSQL image configuration. Apply the same synchronized
correction in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
at lines 77-83 and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
at lines 77-83.
| mkdir -p ~/.ssh | ||
| ssh-keyscan github.com >> ~/.ssh/known_hosts | ||
| eval "$(ssh-agent -a $SSH_AUTH_SOCK)" | ||
| echo "$PRIVATE_KEY" | tr -d '\r' | ssh-add - |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
for f in pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md \
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
do
echo "===== $f ====="
wc -l "$f"
sed -n '70,100p' "$f" | cat -n
echo
doneRepository: Flexberry/flexberry.github.io
Length of output: 2355
🌐 Web query:
GitHub SSH host key fingerprints documentation github.com ssh-keyscan recommended verify host key published fingerprint
💡 Result:
To verify that you are connecting to the legitimate GitHub server, you should compare the SSH host key fingerprint presented by the server during your initial connection attempt against the official fingerprints published by GitHub [1][2]. Official Fingerprints and Keys: You can find the most current and authoritative list of GitHub's SSH key fingerprints and public keys directly in their official documentation [1][3] and via their Meta API endpoint [4]. The Meta API (https://api.github.com/meta) provides the keys in the OpenSSH known_hosts format, which is recommended for preconfiguring systems or CI runners [4]. Verification Process: 1. When you first connect to GitHub via SSH, your client will prompt you to verify the host's authenticity by displaying a fingerprint [2]. 2. You must manually verify that this fingerprint matches the values published on GitHub's official documentation page [1][2]. 3. If the fingerprints match, it is safe to proceed and add the host to your ~/.ssh/known_hosts file [2]. Using ssh-keyscan: While ssh-keyscan is commonly used to gather host keys, it is not inherently secure on its own because it does not verify the host's identity [5][6]. If you use ssh-keyscan to add GitHub to your known_hosts file, you must treat it as a two-step process: 1. Fetch the keys using ssh-keyscan: ssh-keyscan github.com >> github_temp_keys [5][6]. 2. Generate the fingerprint from the fetched key to compare against GitHub's official documentation: ssh-keygen -lf github_temp_keys [5][6]. 3. Only after confirming the fingerprints match should you append the keys to your actual ~/.ssh/known_hosts file [6]. For enhanced security, GitHub recommends keeping your SSH client updated (OpenSSH 7.2 or newer) and using configuration settings like UpdateHostKeys yes in your ~/.ssh/config to help manage key updates securely [7]. If you encounter unexpected host key verification failures, verify the keys against the official sources, as GitHub will announce any host key changes on the GitHub Blog [3][8].
Citations:
- 1: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints
- 2: https://docs.github.com/en/authentication/connecting-to-github-with-ssh/testing-your-ssh-connection
- 3: https://docs.github.com/en/authentication/troubleshooting-ssh/error-host-key-verification-failed
- 4: https://github.blog/changelog/2022-01-18-githubs-ssh-host-keys-are-now-published-in-the-api/
- 5: https://serverfault.com/questions/856194/securely-add-a-host-e-g-github-to-the-ssh-known-hosts-file
- 6: https://stackoverflow.com/questions/49670321/what-is-the-secure-correct-way-of-adding-www-github-com-to-the-known-hosts-file
- 7: https://github.blog/security/application-security/improving-git-protocol-security-github/
- 8: https://github.com/github/docs/blob/main/content/authentication/troubleshooting-ssh/error-host-key-verification-failed.md
Замените ssh-keyscan на официальный источник host key GitHub.
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L88-L91pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L88-L91
ssh-keyscan сам по себе не проверяет подлинность хоста; в примере лучше использовать опубликованные GitHub fingerprints или запись known_hosts из api.github.com/meta.
📍 Affects 2 files
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L88-L91(this comment)pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L88-L91
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md`
around lines 88 - 91, Replace the unauthenticated ssh-keyscan setup in the SSH
initialization block with a trusted GitHub host-key source, using GitHub’s
published fingerprints or the known_hosts data from api.github.com/meta. Apply
the same change in
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md:88-91
and
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md:88-91,
preserving the subsequent ssh-agent and ssh-add steps.
Source: MCP tools
|
|
||
| - name: Wait before mono integration tests (to reduce SIGSEGV risk) | ||
| run: sleep 15 | ||
| ``` No newline at end of file |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Добавьте завершающую newline в оба файла.
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L104-L104pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L104-L104
Это устранит нарушение markdownlint MD047.
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 104-104: Files should end with a single newline character
(MD047, single-trailing-newline)
📍 Affects 2 files
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md#L104-L104(this comment)pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md#L104-L104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md`
at line 104, Добавьте завершающий символ новой строки в
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.en.md
на строке 104 и
pages/products/flexberry-orm/additional-features/fo_ci-cd.github-actions.ru.md
на строке 104, не изменяя содержимое файлов.
Source: Linters/SAST tools
| For detailed migration instructions, see: | ||
| * [Dependency Injection Provider](fo_ds-provider.html) | ||
| * [Current User Service](fo_current-user-service.html) | ||
| * [Unity Factory Migration](fo_unity-factory.html) No newline at end of file |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Добавьте единственный завершающий newline во все перечисленные файлы.
Это необходимо для прохождения MD047.
pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md#L54-L54: добавьте newline.pages/products/flexberry-orm/api/fo_flexberry-orm-api.ru.md#L52-L52: добавьте newline.pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md#L212-L212: добавьте newline.pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md#L119-L119: добавьте newline.pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md#L119-L119: добавьте newline.
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 54-54: Files should end with a single newline character
(MD047, single-trailing-newline)
📍 Affects 5 files
pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md#L54-L54(this comment)pages/products/flexberry-orm/api/fo_flexberry-orm-api.ru.md#L52-L52pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md#L212-L212pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md#L119-L119pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md#L119-L119
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md` at line 54, Add
exactly one trailing newline to each listed Markdown file:
pages/products/flexberry-orm/api/fo_flexberry-orm-api.en.md (line 54),
pages/products/flexberry-orm/api/fo_flexberry-orm-api.ru.md (line 52),
pages/products/flexberry-orm/current-user-service/fo_current-user-service.en.md
(line 212),
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md (line
119), and pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md
(line 119).
Source: Linters/SAST tools
| ## CRP Generation Issues | ||
|
|
||
| > **Important:** After regenerating CRP, Flexberry Designer versions before .NET 6+ do not support `DateOnly` type in .NET 6+ projects. | ||
|
|
||
| After updating the .crp file and running the code generator, the generated PostgreSQL SQL script may contain incorrect data types for tables with `DateOnly` (e.g., `TIMESTAMP(3)` instead of `DATE`). | ||
|
|
||
| **Solution:** Manually replace the table creation script with `DateOnly` in the generated .sql file so that the column uses the correct `DATE` type. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Сделать предупреждение CRP однозначным в обеих версиях.
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md#L73-L79: убрать формулировкуbefore .NET 6+.pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md#L71-L77: указать точную границу поддержки Designer.
📍 Affects 2 files
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md#L73-L79(this comment)pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md#L71-L77
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md`
around lines 73 - 79, Clarify the CRP generation warning in both documentation
versions: in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.en.md lines
73-79, remove the ambiguous “before .NET 6+” wording; in
pages/products/flexberry-orm/data-service/fo_postgres-data-service.ru.md lines
71-77, specify the exact Designer support boundary. Keep the warning’s
DateOnly/DATE correction guidance unchanged.
| [Flexberry ORM](fo_flexberry-orm.html) allows you to work with the following types: | ||
|
|
||
| * .Net basic types (such as int, string, float, etc.) | ||
| * .Net [Nullable-types](fd_nullable-types.html). | ||
| * [User defined types](fo_convert-type-property.html). | ||
| * [Nullable types NullableDateTime, NullableInt, NullableDecimal](fd_nullable-types.html) (located in the Assembly ICSSoft.STORMNET.UserDataTypes): | ||
| * Optional types [Flexberry ORM](fo_flexberry-orm.html) (these types are serialized in XML format by Implicit transformations and is stored in a database (or other storage) in a serialized виде; the search attributes specified types can be produced only by a substring and this is the main difference from the full structure данных; are located in the Assembly ICSSoft.STORMNET.UserDataTypes). | ||
| * Contact - a contact of the user (client or any other person). | ||
| * Event - a calendar event. | ||
| * GeoData - GEODATA (`Feature`). | ||
| * Image - the image. | ||
| * WebFile - a Web file. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Перевести и вычитать список типов.
В английском тексте остались русские слова (виде, данных) и некорректные конструкции вроде Optional types Flexberry ORM. Также используйте User-defined types с дефисом. Сейчас раздел выглядит незавершённым для англоязычного читателя.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~17-~17: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...able-types](fd_nullable-types.html). * User defined types. ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/data-types/fo_flexberry-orm-types.en.md` around
lines 13 - 24, Revise the type list in the Flexberry ORM documentation to use
clear, grammatically correct English throughout: replace the Russian words in
the optional-types description, correct the “Optional types Flexberry ORM”
construction, and consistently write “User-defined types” with a hyphen.
Preserve the existing type entries and links while ensuring the section reads as
complete English documentation.
| * `UnityFactory` - no longer used for resolving dependencies: | ||
| ```csharp | ||
| // Before | ||
| IUnityContainer container = UnityFactory.GetContainer(); | ||
| IViewGenerator resolvedType = container.Resolve<IViewGenerator>(); | ||
|
|
||
| // After | ||
| IViewGenerator resolvedType = DetailVariableDef.ViewGenerator; | ||
| ``` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== File line excerpts ==\n'
for f in \
"pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md" \
"pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md" \
"pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md" \
"pages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md"
do
echo "--- $f ---"
sed -n '85,120p' "$f" | cat -n
echo
done
printf '\n== Search for DetailVariableDef.ViewGenerator and UnityFactory context ==\n'
rg -n "DetailVariableDef\.ViewGenerator|UnityFactory|явное DI|explicit DI|dependency injection|DI" pages/products/flexberry-orm/dependency-injection -SRepository: Flexberry/flexberry.github.io
Length of output: 10386
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Exact excerpts around cited lines ==\n'
for f in \
"pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md" \
"pages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md"
do
echo "--- $f ---"
sed -n '43,58p' "$f" | cat -n
echo
done
printf '\n== All repository mentions of DetailVariableDef.ViewGenerator / DetailVariableDef ==\n'
rg -n "DetailVariableDef(\.ViewGenerator)?|ViewGenerator" . -SRepository: Flexberry/flexberry.github.io
Length of output: 16789
Уточните формулировку про DI
Во всех четырёх местах после миграции показан не явный DI-контракт, а присваивание статического DetailVariableDef.ViewGenerator. Лучше либо заменить формулировку на переход к DetailVariableDef.ViewGenerator, либо явно пояснить, что это отдельный API, а не пример внедрения зависимости.
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.mdpages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.mdpages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.mdpages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 100-100: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
📍 Affects 4 files
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md#L99-L107(this comment)pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md#L99-L107pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md#L49-L57pages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md#L47-L55
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md`
around lines 99 - 107, The DI documentation currently describes static
DetailVariableDef.ViewGenerator assignment as dependency injection. Update the
wording and examples to describe the transition to
DetailVariableDef.ViewGenerator, or explicitly identify it as a separate API
rather than an injected dependency. Apply the same correction in
pages/products/flexberry-orm/dependency-injection/fo_ds-provider.en.md lines
99-107, pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md
lines 99-107,
pages/products/flexberry-orm/dependency-injection/fo_unity-factory.en.md lines
49-57, and
pages/products/flexberry-orm/dependency-injection/fo_unity-factory.ru.md lines
47-55.
| `DataServiceProvider.DataService` - это [сервис данных](fo_data-service.html), который инициализируется на основании параметров, заданных в файле конфигурации (`App.config` или `Web.config`). Таким образом, `DataServiceProvider.DataService` является [сервисом данных](fo_data-service.html) по умолчанию. | ||
|
|
||
| ### Алгоритм инициализации DataServiceProvider.DataService | ||
| ### Алгоритм инициализации DataServiceProvider.DataService |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Исправьте уровень заголовка.
Первый заголовок документа имеет уровень ###, поэтому MD001 ожидает ##.
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 15-15: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/dependency-injection/fo_ds-provider.ru.md` at
line 15, Измените заголовок «Алгоритм инициализации
DataServiceProvider.DataService» с уровня ### на ##, чтобы он соответствовал
уровню первого заголовка документа и правилу MD001.
Source: Linters/SAST tools
| ## LINQ to LCS conversion | ||
|
|
||
|
|
||
| For detailed information about converting LINQ queries to LCS (Language Control System) see [LCS to LINQ](fo_lcs-to-linq.html). No newline at end of file |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Исправить направление ссылки LINQ/LCS в обеих локализациях.
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md#L256-L258: согласовать заголовок и целевую страницу.pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.ru.md#L253-L256: внести то же исправление в русскую версию.
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 258-258: Files should end with a single newline character
(MD047, single-trailing-newline)
📍 Affects 2 files
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md#L256-L258(this comment)pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.ru.md#L253-L256
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md`
around lines 256 - 258, Correct the LINQ/LCS link direction so the “LINQ to LCS
conversion” heading in
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.en.md
lines 256-258 links to the matching LINQ-to-LCS page, and apply the same aligned
heading and target correction in
pages/products/flexberry-orm/query-language/fo_linq-provider-faetures.ru.md
lines 253-256.
1 participant
Summary by CodeRabbit
DateOnlyиTimeOnlyв сервисах данных и LINQ.