Architecture review: remediate phone, Wear, and presentation - #98
Open
Foxpace wants to merge 2 commits into
Open
Architecture review: remediate phone, Wear, and presentation#98Foxpace wants to merge 2 commits into
Foxpace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the phone, Wear, and presentation half of the architecture review. This PR is stacked on #97 and must ship with its Wear protocol changes on both apps.
SensorReportingModeand an exhaustive platform mapper withUNKNOWN.Compatibility
typekey with the fixed valueRECORDING; all historical keys and value types remain unchanged.Verification
./gradlew test detekt lint assembleDebug assembleAndroidTest— passed, 488 tasks.git diff --check— passed.tools/emulator/run_phone_sensor_test.sh— passed onemulator-5554(OK (1 test)).tools/emulator/run_wear_sync_test.sh— passed between pairedemulator-5554andemulator-5556; both the Wear sender and phone receiver reportOK (1 test).app,wear,sensorservices, andWearOsLibreturns no heart-rate capability or permission references. The only remaining heart-rate constants are negative assertions in discovery tests.ENDLESS/TIMEDmode values.Inline review disposition
volatileremoved.MutablePreferencesimport.EpochClock.SensorReportingMode, exhaustive Android mapping, andUNKNOWN.MsgListener; its one Hilt-injected dispatcher field remains, and the listener stays a thin adapter.