fix(miniapp): allow strict runtime downloads - #2598
Merged
nonoqing merged 1 commit intoAug 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Market MiniApps render inside a sandboxed iframe. The strict profile previously used only
allow-scripts, so the webview blocked the standard Blob URL +<a download>flow even when the MiniApp generated the file locally. This made result-card downloads fail while the non-strict runtime already supported downloads.Security boundary
This adds only
allow-downloads. The strict iframe still does not receiveallow-same-origin, forms, modals, popups, or filesystem access.Verification
pnpm --dir src/web-ui run test:run src/app/scenes/miniapps/components/MiniAppRunner.test.tsx(1 passed)pnpm --dir src/web-ui run gen:types(36 Rust export tests passed)pnpm run check:websandbox="allow-scripts allow-downloads"Remote workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not exercised; this change is limited to the local Web UI iframe sandbox attribute.
AI assistance
AI-assisted change, locally verified with the focused regression test and Web UI checks listed above.