fix(explore): backport #2565 and adapt #2595 - #2601
Open
guantw wants to merge 2 commits into
Open
Conversation
DeepReview remediation changes a manager-owned session binding before the turn is admitted. The admission snapshot must track the effective route owner and all execution-affecting session bindings so stale configuration cannot start a turn. Synchronize the turn-local snapshot after the ReviewFixer binding update and reject concurrent model, route, context-window, and workspace binding changes. Add regression coverage for the successful remediation path and admission races.
guantw
force-pushed
the
codex/backport-session-permission-fixes-explore
branch
2 times, most recently
from
August 28, 2026 12:52
961cb73 to
dc1ee15
Compare
Adapt GCWing#2595 to the Explore composer architecture. The primary composer handles only requests owned by the primary session, while embedded BTW and review panels expose direct child-session requests through the shared approval band. Delegated requests remain actionable only from the parent surface. Repair stale design-system test mocks and normalize a cross-platform stylesheet fixture inherited from the latest Explore base so the full frontend suite passes on Linux and Windows checkouts.
guantw
force-pushed
the
codex/backport-session-permission-fixes-explore
branch
from
August 28, 2026 12:56
dc1ee15 to
0c98028
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewFixer, and admission rejects concurrent execution-affecting binding changes.1.0.0-exploreUI instead of restoring the removedPermissionRequestPanel.ChatInputApprovalBandinside embedded BTW/review panels so standalone child sessions can answer direct requests.@bitfun/uimocks and a Windows CRLF-sensitive stylesheet fixture inherited from the latest Explore base; these were exposed by full PR/local frontend suites.Explore-specific adaptation
1.0.0-exploremoved approvals into the composer and removed the old floating permission panel. The primary composer therefore consumes only requests owned by the primary session, whileBtwSessionPanelrenders owner-only direct child requests with the shared compact approval band. Transcript pending state still uses the broader projection.During review, I found that using the composer's effective target session would duplicate a direct child approval whenever the target switcher pointed at the open child panel. The composer is now bound to the primary session's ownership projection; the child panel exclusively owns the child request. Regression coverage locks this routing down.
Verification
cargo test -p bitfun-core --no-default-features --features agent-runtime,git --lib dialog_turn_admission_rejects— 4 passedcargo test -p bitfun-core --no-default-features --features agent-runtime,git --lib agentic::coordination::coordinator::tests::review_fixer_turn_is_admitted_after_updating_a_deep_review_session_binding— 1 passedpnpm --dir src/web-ui run type-checkpnpm run theme:color-audit:allpnpm run appearance:contract-auditRemote scenarios
Permission responses continue through the existing per-session driver/mailbox abstraction, so no local fallback was introduced. Local Web UI and unit-level routing were exercised; remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not end-to-end exercised in this change.