refactor: limit magic paths use#4102
Open
kdrienCG wants to merge 5 commits into
Open
Conversation
kdrienCG
requested review from
MelReyCG,
OmarDuran,
acitrain,
bd713,
corbett5,
cssherman,
dkachuma,
frankfeifan,
jafranc,
jhuang2601,
joshua-white,
rrsettgast,
sframba,
tjb-ltk and
wrtobin
as code owners
July 23, 2026 15:27
kdrienCG
marked this pull request as draft
July 23, 2026 15:28
kdrienCG
marked this pull request as ready for review
July 23, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the use of magic paths to access common objects for developers (
"/Problem/domain/","/Problem/domain/Constitutive","/Problem/Events/", etc)It introduces a
GlobalViewKeysstruct to provide a centralized definition of the names of these common objects.It also adds a
ProblemManagerBaselightweight interface over theProblemManagerthat gives typed access to these objects without requiring to bring the fullProblemManagerExample of its use:
is replaced by:
PhysicsSolverManager & physicsSolverManager = getProblemManagerBase( *this ).getPhysicsSolverManager();