Fix the text transparency ramp during the rise phase (-Et+r) for labels#9090
Merged
Conversation
joa-quim
approved these changes
Jul 6, 2026
joa-quim
left a comment
Member
There was a problem hiding this comment.
Seems pretty harmless if it woks.
Member
Author
|
It is also coherent with the funcion for symbols |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done by Claude Sonnet 5
Description
The rise-phase transparency was incorrectly computed using PSEVENTS_DECAY instead of PSEVENTS_RISE. Since labels do not have a decay phase, this resulted in a division by zero and generated Inf/NaN transparency values. Consequently, pstext fell back to fully opaque text and issued a warning as described in #8328
Testing
This can be reproduced with:
Fixed:
With this fix, the generated frame shows a partially transparent label (~60% transparency).

Without fix:
Without this fix, the label is rendered fully opaque and GMT reports a warning about an invalid transparency value.
Fixes #8328