POC: WIP: Figure.inset: Set the default position to the top right#4721
Draft
yvonnefroehlich wants to merge 2 commits into
Draft
POC: WIP: Figure.inset: Set the default position to the top right#4721yvonnefroehlich wants to merge 2 commits into
yvonnefroehlich wants to merge 2 commits into
Conversation
yvonnefroehlich
added
maintenance
Member
|
I prefer not to change the default behavior, because it's backward incompatible. |
Member
Author
|
Should we add a note for the differing defaults? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4702, but for
Figure.inset.PyGMT uses the default
Position((0, 0), cstype="plotcoords"), but for GMT > 6.6.0 the default in GMT isTR.The defaults should be consistent across GMT and PyGMT, however this causes breaking backward compatibility.
Need to disscuss and decide how to proceed here.
Fixes #
Preview:
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code