Fix the baseline image for test_text_position_offset_with_line.png - #4803
Merged
Conversation
seisman
added
maintenance
seisman
commented
Aug 8, 2026
Comment on lines
+174
to
+179
| # TODO(GMT>=6.7.0): Remove the conditional filename when the minimum version is reached. | ||
| @pytest.mark.mpl_image_compare( | ||
| filename="test_text_position_offset_with_line.png" | ||
| if Version(__gmt_version__) >= Version("6.7.0") | ||
| else "test_text_position_offset_with_line_legacy.png" | ||
| ) |
Member
Author
There was a problem hiding this comment.
Use different baseline image based on GMT version, so that the test passes in both the Tests and Legacy Tests workflows.
seisman
added
the
final review call
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4801.
The baseline change is caused by an upstream GMT change, but I can't find the upstream PR (likely GenericMappingTools/gmt#8965).