fix: drop server-side remnants, add WS interface - #1819
Open
arnautov-anton wants to merge 2 commits into
Open
Conversation
arnautov-anton
requested review from
MartinCupela,
isekovanic,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
August 11, 2026 15:31
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
drop-server-side-remnants
branch
from
August 11, 2026 16:28
1b48929 to
2790716
Compare
arnautov-anton
commented
Aug 11, 2026
Comment on lines
+103
to
113
| export function addFileToFormData(uri: string | Blob, name?: string) { | ||
| const data = new FormData(); | ||
|
|
||
| if (isReadableStream(uri) || isBuffer(uri) || isFileWebAPI(uri) || isBlobWebAPI(uri)) { | ||
| if (isBlobWebAPI(uri)) { | ||
| if (name) data.append('file', uri, name); | ||
| else data.append('file', uri); | ||
| } else { | ||
| data.append('file', { | ||
| uri, | ||
| name: name || (uri as string).split('/').reverse()[0], | ||
| contentType: contentType || undefined, | ||
| type: contentType || undefined, | ||
| }); | ||
| data.append('file', uri); | ||
| } | ||
|
|
||
| return data; |
Contributor
Author
There was a problem hiding this comment.
This right here is the biggest change and would need some testing from RN guys too, not sure whether this is the correct typing. @isekovanic
arnautov-anton
commented
Aug 11, 2026
Comment on lines
+345
to
+346
| const WS = this.client.options.WebSocketImpl ?? WebSocket; | ||
| this.ws = new WS(wsURL); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?