fix(spm): drop stale Package.resolved for non-root Swift packages - #87
Open
Brazol wants to merge 1 commit into
Open
fix(spm): drop stale Package.resolved for non-root Swift packages#87Brazol wants to merge 1 commit into
Brazol wants to merge 1 commit into
Conversation
`Package.swift` pins `stream-video-swift-webrtc` at `exact: "145.17.0"`, but every committed lock file disagreed with it: Package.resolved 145.9.0 ios/stream_webrtc_flutter/Package.resolved 145.6.0 macos/stream_webrtc_flutter/Package.resolved 145.6.0 example/ios/**/Package.resolved 145.16.0 example/macos/**/Package.resolved 145.9.0 SwiftPM ignores the lock of a non-root package, so the first three never affected what a consuming app resolved - they were pure drift, and they get published to pub.dev where integrators find them. Chasing a customer's "no versions of 'stream-video-swift-webrtc' match the requirement 145.17.0" report, these files were the first thing that looked like a cause and cost real time to rule out. Remove them and add .gitignore rules so they don't come back. The example apps' locks are root-level and stay tracked, refreshed to 145.17.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package.swiftpinsstream-video-swift-webrtcatexact: "145.17.0", but every committed lock file disagreed with it:Package.resolved 145.9.0
ios/stream_webrtc_flutter/Package.resolved 145.6.0
macos/stream_webrtc_flutter/Package.resolved 145.6.0
example/ios//Package.resolved 145.16.0
example/macos//Package.resolved 145.9.0
SwiftPM ignores the lock of a non-root package, so the first three never affected what a consuming app resolved - they were pure drift, and they get published to pub.dev where integrators find them. Chasing a customer's "no versions of 'stream-video-swift-webrtc' match the requirement 145.17.0" report, these files were the first thing that looked like a cause and cost real time to rule out.
Remove them and add .gitignore rules so they don't come back. The example apps' locks are root-level and stay tracked, refreshed to 145.17.0.