Skip to content

fix: update GitHub Actions to Node 24 runtime versions - #195

Merged
ajma merged 3 commits into
mainfrom
fix/pin-actions-node24
Sep 16, 2026
Merged

ajma merged 3 commits into
mainfrom
fix/pin-actions-node24

Conversation

@ajma

@ajma ajma commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • All four workflows (tests.yaml, pyink.yaml, lint-readme.yaml, integration-tests.yaml) pinned actions/checkout, actions/setup-python, and actions/cache to versions that still declare using: node20, which GitHub force-upgrades at runtime with a deprecation warning on every run.
  • Bumped each action to the latest major that declares node24 natively (verified directly against each action's action.yml, not just version numbers): checkout v4→v7.0.1, setup-python v5→v7.0.0, cache v4→v6.1.0, and in integration-tests.yaml, google-github-actions/auth v2→v3 and google-github-actions/setup-gcloud v2→v3.0.1.
  • Pinned every action reference to a full commit SHA (with the version as a trailing comment) to satisfy the org's zizmor unpinned-uses policy, matching the pattern integration-tests.yaml already used.
  • Added permissions: contents: read to tests.yaml and pyink.yaml to resolve zizmor's overly-broad-permissions finding, matching lint-readme.yaml and integration-tests.yaml.
  • Checked release notes for all bumped majors — no breaking changes affect the inputs used here (persist-credentials, python-version, path/key/restore-keys, credentials_json).

Note: two other warnings (Feature flags do not specify a default CLI version, a CodeQL API permission notice) come from .github/workflows/action_scanning.yml, which isn't part of this repo — it's an org-level required workflow, so it's out of scope here.

Test plan

  • python3 -c "import yaml; ..." — all four workflow YAML files parse successfully
  • zizmor-output check passes on this PR

actions/checkout, actions/setup-python, actions/cache, and the
google-github-actions auth/setup-gcloud actions were pinned to
versions that still target the deprecated Node 20 runtime, which
GitHub now force-upgrades with a warning on every run. Bump each to
the latest major that declares node24 in its own action metadata.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

The org's zizmor security scan mandatorily requires every action
reference to be pinned to a full commit SHA, not a floating tag.
Apply the same SHA + version-comment pattern already used in
integration-tests.yaml to the remaining three workflows.
zizmor flags the missing permissions block as overly broad (Medium
severity), since the default GITHUB_TOKEN grants broader access than
these jobs need. Both only checkout and run tests/lint, so
contents:read matches lint-readme.yaml and integration-tests.yaml.
@ajma
ajma force-pushed the fix/pin-actions-node24 branch from 7fe06dc to 9cd053d Compare September 12, 2026 21:39
@GoogleCloudDataproc GoogleCloudDataproc deleted a comment from google-cla Bot Sep 13, 2026
@ajma
ajma merged commit 6296265 into main Sep 16, 2026
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants