Skip to content

Fix dev environment configurations with devcontainer, vscode, and cargo-about - #4372

Merged
Keavon merged 1 commit into
GraphiteEditor:masterfrom
dzil123:developer-onboarding-fixes-devcontainer
Sep 5, 2026
Merged

Fix dev environment configurations with devcontainer, vscode, and cargo-about#4372
Keavon merged 1 commit into
GraphiteEditor:masterfrom
dzil123:developer-onboarding-fixes-devcontainer

Conversation

@dzil123

@dzil123 dzil123 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Some minor fixes to issues I ran into using devcontainer on this project with vscode.

  • Add esbenp.prettier-vscode to the recommended extensions list as it's already used in .vscode/settings.json
  • Install wasm32-unknown-unknown Rust target in devcontainer
  • Add cargo-binstall and pin cargo-about version in devcontainer
  • Remove no-clearly-defined = true from about.toml:
    • cargo-about 0.9.1 fails to run if no-clearly-defined is present
    • cargo-about 0.8.0 already removed support for clearlydefined.io, so the argument is a no-op

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .gitignore
@TrueDoctor

Copy link
Copy Markdown
Member

This looks reasonable, thoughts @Keavon ?

@Keavon

Keavon commented Jul 27, 2026

Copy link
Copy Markdown
Member

Please leave the requested comment in #4208 and then we should be able to merge this after I give it a review (hopefully today).

@Keavon
Keavon force-pushed the developer-onboarding-fixes-devcontainer branch from 2b8b04c to 3e4e343 Compare September 5, 2026 20:13

@Keavon Keavon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these contributions, sorry it took so long to remember about this.

@Keavon Keavon changed the title Developer onboarding fixes - devcontainer, vscode, cargo-about Fix dev environment configurations with devcontainer, vscode, and cargo-about Sep 5, 2026
@Keavon
Keavon added this pull request to the merge queue Sep 5, 2026
Merged via the queue into GraphiteEditor:master with commit 4d9a626 Sep 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants