-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add RFC for the attribute system #4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrueDoctor
wants to merge
14
commits into
pre-rank-poly
Choose a base branch
from
node-attributes-rfc
base: pre-rank-poly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+902
−11
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
00e40b4
Add RFC for the attribute system
TrueDoctor 32068fc
Remove concept of sampled nodes
TrueDoctor f01429f
Fix the record buffer liveness rule and the index accessor
TrueDoctor 18225d0
Move evaluation to use a stack
TrueDoctor fa76237
Align RFC summary, soundness, and rationale with the stack model
TrueDoctor d1779e8
Update rfc with new tuple syntax for inputs
TrueDoctor c01fb08
Update rfc
TrueDoctor 658f378
Align rfc with implementation
TrueDoctor d0dae48
Rewrite the runtime representation to the landed frame model
TrueDoctor c93395b
Add the arena, promotion, memo, and owned crossing reference
TrueDoctor 5d967a6
Adopt the input and source vocabulary
TrueDoctor 2e1d9c0
Update the soundness section to the landed enforcement
TrueDoctor b58d2ab
Record the settled level and generic-name decisions
TrueDoctor 9a08514
Align the async execution RFC with the serve substrate
TrueDoctor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This change removes
type Outputfrom theNodetrait but remains referenced in multiple RFC sections (e.g., "Lazy inputs (content: impl Node<Output = T>)"; the exampleimpl<'e> Node<Context<'e>> for Lend { type Output = &'e T; }; and "dyn for<'a> Node<Context<'a>, Output = u32>"), plus the rationale that "any lifetime in the output can only come from the input type" is outdated givenservenow returnsGPoll<Served<'e>>with'esourced fromFrameClaim<'e, 'l>. This inconsistency must be resolved to keep the record model aligned with the rest of the document.Prompt for AI agents
+With the record model there is no
Outputassociated type: every node+serves a record whose layout is wiring state, the element at offset 0,
+and
serveis the one required method. The caller mints the claim out</file context>