Fix CMAC processing and add test coverage - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
xorVecsafe when its output aliases either inputWhy
The previous loop advanced a block counter by the AES block size, so messages longer than one block were not fully processed. The helper also cleared an aliased output before reading the input, which was undefined behavior and was detected under AddressSanitizer. Empty messages attempted to access a nonexistent final block.
Besides correcting those paths, this removes accidental cryptographic subkey output and gives contributors reproducible tests and build instructions.
Validation
c++ -std=c++17 -Wall -Wextra -Wpedantic ...build: passgit diff --check: passCMake is not installed in the local environment, so the equivalent direct compiler commands were used locally. The PR workflow runs the documented CMake/CTest path on Ubuntu.