fix(SDK-1272): move the print-checks CTA below the description - #2720
Open
krisxcrash wants to merge 1 commit into
Open
fix(SDK-1272): move the print-checks CTA below the description#2720krisxcrash wants to merge 1 commit into
krisxcrash wants to merge 1 commit into
Conversation
The button was passed via Alert's action prop, which composes into the header row beside the label -- an unusual spot for a CTA, per report. Moves it into children, below the description, matching the same composition TransitionPayrollAlertPresentation already uses for its own alert CTAs.
krisxcrash
marked this pull request as ready for review
September 4, 2026 23:36
serikjensen
requested changes
Sep 8, 2026
Comment on lines
+52
to
+62
| <Alert status="info" label={t('title', { count: checkPaymentsCount })}> | ||
| <Flex flexDirection="column" gap={16}> | ||
| <Text>{t('description')}</Text> | ||
| {isProcessed && ( | ||
| <div> | ||
| <Button variant="secondary" onClick={onStartPrintChecks}> | ||
| {t('cta')} | ||
| </Button> | ||
| </div> | ||
| )} | ||
| </Flex> |
Member
There was a problem hiding this comment.
@krisxcrash i think aaron should weigh in on this one! We should be using the action prop so that partners with alerts that have CTAs get properly placed when they are mapping to their own alert. If this was non designer feedback i think it can just be ignored. Otherwise it's worth it to have a chat with Aaron to globally more the alert action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alert'sactionprop, which composes into the header row beside the label/icon — documented as intended for compact, inline CTAs next to a title, not a CTA below body copy.PrintChecksBannerwas the only production caller passingactiontoAlert, so no other usage is affected.children, below the description, matching the exact compositionTransitionPayrollAlertPresentationalready uses for its own alert CTAs (descriptionText, then button(s) below, noactionprop).Jira: SDK-1272
Test plan
PrintChecks*.test.tsxpass (24/24)eslint/tsc --noEmitclean